Spanner MR CMEK Integration #11319

panerorenn9541 · 2024-08-01T00:14:32Z

Promote Spanner MR CMEK support to GA:

Adds the new field kmsKeyNames to encryptionConfig to support creating a Spanner MR CMEK database.

Release Note Template for Downstream PRs (will be copied)

spanner: added `kmsKeyNames` to encryptionConfig of Database

- Add kmsKeyNames to encryptionConfig - Make kmsKeyName and kmsKeyNames not required

Add MR CMEK test

Mr cmek integration

mmv1/products/spanner/Database.yaml

Add https://googlecloudplatform.github.io/magic-modules/develop/field-reference/#exactly_one_of for KmsKeyName and KmsKeyNames?

rahul2393

LGTM

github-actions · 2024-08-07T19:15:15Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2024-08-07T20:46:00Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 38 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 173 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

modular-magician · 2024-08-07T20:47:32Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 38 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 173 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

modular-magician · 2024-08-07T20:49:33Z

Tests analytics

Total tests: 30
Passed tests: 18
Skipped tests: 12
Affected tests: 0

Click here to see the affected service packages

spanner

#### Non-exercised tests

Tests were added that are skipped in VCR:

TestAccSpannerDatabase_mrcmek
$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

modular-magician · 2024-08-07T20:50:56Z

Tests analytics

Total tests: 30
Passed tests: 18
Skipped tests: 12
Affected tests: 0

Click here to see the affected service packages

spanner

#### Non-exercised tests

Tests were added that are skipped in VCR:

TestAccSpannerDatabase_mrcmek
$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

c2thorn

can you update the release note based on https://googlecloudplatform.github.io/magic-modules/contribute/release-notes/

I'll run the test in our environment to make sure its passing

mmv1/third_party/terraform/services/spanner/resource_spanner_database_test.go.erb

panerorenn9541 · 2024-08-07T21:50:21Z

can you update the release note based on https://googlecloudplatform.github.io/magic-modules/contribute/release-notes/

I'll run the test in our environment to make sure its passing

Added a note.

c2thorn

=== RUN   TestAccSpannerDatabase_mrcmek
=== PAUSE TestAccSpannerDatabase_mrcmek
=== CONT  TestAccSpannerDatabase_mrcmek
    vcr_utils.go:152: Step 1/2 error: Error running apply: exit status 1
        Error: Error creating Database: googleapi: Error 400: Invalid CreateDatabase request.
        Details:
        [
          {
            "@type": "type.googleapis.com/google.rpc.BadRequest",
            "fieldViolations": [
              {
                "description": "Expected projects/{project ID}/locations/{location ID}/keyRings/{keyring ID}/cryptoKeys/{kms_key_name}\nGot: google_kms_crypto_key.example-key-us-central1.id\nError: Resource name 'google_kms_crypto_key.example-key-us-central1.id' does not match pattern 'projects/([^/]{1,100})/locations/([a-zA-Z0-9_-]{1,63})/keyRings/([a-zA-Z0-9_-]{1,63})/cryptoKeys/([a-zA-Z0-9_-]{1,63})'.",
                "field": "encryption_config.kms_key_names[0]"
              }
            ]
          }
        ]
          with google_spanner_database.database,
          on terraform_plugin_test.tf line 9, in resource "google_spanner_database" "database":
           9: resource "google_spanner_database" "database" {

….erb

panerorenn9541 · 2024-08-09T00:24:25Z

I am seeing the error "The Cloud Spanner multi-region CMEK feature is currently not supported"

modular-magician · 2024-08-09T00:26:23Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 38 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 173 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

modular-magician · 2024-08-09T00:28:57Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 38 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 173 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

Use spaces rather than tabs

modular-magician · 2024-10-11T00:05:11Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 83 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 219 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

Use spaces instead of tabs

Change description of kmsKeyNames to use plurals

…ey_names.go.tmpl Clarify comment Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

modular-magician · 2024-10-11T00:22:45Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 83 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 219 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

modular-magician · 2024-10-11T00:24:09Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 83 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 219 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

Use spaces instead of tabs

modular-magician · 2024-10-11T00:32:01Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 83 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 219 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

modular-magician · 2024-10-11T00:35:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 83 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 219 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

Use BootstrapKMSKey instead of crypto keys because crypto keys can't be deleted

modular-magician · 2024-10-11T01:16:22Z

Tests analytics

Total tests: 4153
Passed tests: 3730
Skipped tests: 418
Affected tests: 5

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

Tests were added that are skipped in VCR:

TestAccSpannerDatabase_mrcmek

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBackupDRBackupVault_fullUpdate

TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample

TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample

TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample

TestAccDataformRepository_updated

Get to know how VCR tests work

modular-magician · 2024-10-11T01:22:42Z

🟢 Tests passed during RECORDING mode:
TestAccBackupDRBackupVault_fullUpdate[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample[Error message] [Debug log]
TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample[Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample[Error message] [Debug log]
TestAccDataformRepository_updated[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-10-11T01:25:07Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 83 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 189 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

modular-magician · 2024-10-11T01:32:20Z

Tests analytics

Total tests: 4153
Passed tests: 3730
Skipped tests: 418
Affected tests: 5

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

Tests were added that are skipped in VCR:

TestAccSpannerDatabase_mrcmek

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBackupDRBackupVault_fullUpdate

TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample

TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample

TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample

TestAccDataformRepository_updated

Get to know how VCR tests work

modular-magician · 2024-10-11T01:33:41Z

Tests analytics

Total tests: 4153
Passed tests: 3730
Skipped tests: 418
Affected tests: 5

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

Tests were added that are skipped in VCR:

TestAccSpannerDatabase_mrcmek

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBackupDRBackupVault_fullUpdate

TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample

TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample

TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample

TestAccDataformRepository_updated

Get to know how VCR tests work

modular-magician · 2024-10-11T01:38:18Z

🟢 Tests passed during RECORDING mode:
TestAccBackupDRBackupVault_fullUpdate[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample[Error message] [Debug log]
TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample[Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample[Error message] [Debug log]
TestAccDataformRepository_updated[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-10-11T01:39:36Z

🟢 Tests passed during RECORDING mode:
TestAccBackupDRBackupVault_fullUpdate[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample[Error message] [Debug log]
TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample[Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample[Error message] [Debug log]
TestAccDataformRepository_updated[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-10-11T01:42:06Z

Tests analytics

Total tests: 4152
Passed tests: 3729
Skipped tests: 418
Affected tests: 5

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

Tests were added that are skipped in VCR:

TestAccSpannerDatabase_mrcmek

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBackupDRBackupVault_fullUpdate

TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample

TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample

TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample

TestAccDataformRepository_updated

Get to know how VCR tests work

modular-magician · 2024-10-11T01:46:17Z

Tests analytics

Total tests: 4153
Passed tests: 3730
Skipped tests: 418
Affected tests: 5

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

Tests were added that are skipped in VCR:

TestAccSpannerDatabase_mrcmek

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBackupDRBackupVault_fullUpdate

TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample

TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample

TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample

TestAccDataformRepository_updated

Get to know how VCR tests work

modular-magician · 2024-10-11T01:48:14Z

🟢 Tests passed during RECORDING mode:
TestAccBackupDRBackupVault_fullUpdate[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample[Error message] [Debug log]
TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample[Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample[Error message] [Debug log]
TestAccDataformRepository_updated[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-10-11T01:52:35Z

🟢 Tests passed during RECORDING mode:
TestAccBackupDRBackupVault_fullUpdate[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample[Error message] [Debug log]
TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample[Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample[Error message] [Debug log]
TestAccDataformRepository_updated[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-10-11T02:44:05Z

Tests analytics

Total tests: 4153
Passed tests: 3731
Skipped tests: 418
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

Tests were added that are skipped in VCR:

TestAccSpannerDatabase_mrcmek

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample

TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample

TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample

TestAccDataformRepository_updated

Get to know how VCR tests work

modular-magician · 2024-10-11T02:49:11Z

🔴 Tests failed during RECORDING mode:
TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample[Error message] [Debug log]
TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample[Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample[Error message] [Debug log]
TestAccDataformRepository_updated[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

ScottSuarez · 2024-10-11T22:10:21Z

mmv1/third_party/terraform/services/spanner/resource_spanner_database_test.go.tmpl

+resource "google_kms_crypto_key_iam_binding" "crypto_key1" {
+  crypto_key_id = "%{key_name1}"
+  role          = "roles/cloudkms.cryptoKeyEncrypterDecrypter"
+  members = [
+    google_project_service_identity.ck_sa.member,
+  ]
+}
+
+resource "google_kms_crypto_key_iam_binding" "crypto_key2" {
+  crypto_key_id = "%{key_name2}"
+  role          = "roles/cloudkms.cryptoKeyEncrypterDecrypter"
+  members = [
+    google_project_service_identity.ck_sa.member,
+  ]
+}
+
+resource "google_kms_crypto_key_iam_binding" "crypto_key3" {
+  crypto_key_id = "%{key_name3}"
+  role          = "roles/cloudkms.cryptoKeyEncrypterDecrypter"
+  members = [
+    google_project_service_identity.ck_sa.member,
+  ]
+}


Can you remove these IAM roles? I'll manually add them once done. Then we should be good to go here.

panerorenn9541 added 5 commits July 31, 2024 13:33

Update Database.yaml

b43da49

- Add kmsKeyNames to encryptionConfig - Make kmsKeyName and kmsKeyNames not required

Change kms_key_names to kmsKeyNames in description

a7e959f

Update resource_spanner_database_test.go.erb

0f58e19

Add MR CMEK test

Merge pull request #1 from panerorenn9541/mr-cmek-integration

be9a029

Mr cmek integration

Merge branch 'GoogleCloudPlatform:main' into main

4a0d02f

rahul2393 reviewed Aug 5, 2024

View reviewed changes

mmv1/products/spanner/Database.yaml Outdated Show resolved Hide resolved

mmv1/products/spanner/Database.yaml Outdated Show resolved Hide resolved

panerorenn9541 added 2 commits August 5, 2024 10:52

Update Database.yaml

50929aa

Add https://googlecloudplatform.github.io/magic-modules/develop/field-reference/#exactly_one_of for KmsKeyName and KmsKeyNames?

Merge branch 'GoogleCloudPlatform:main' into main

aed43a4

rahul2393 approved these changes Aug 6, 2024

View reviewed changes

panerorenn9541 marked this pull request as ready for review August 7, 2024 19:14

panerorenn9541 requested a review from rahul2393 August 7, 2024 19:15

github-actions bot requested a review from c2thorn August 7, 2024 19:15

panerorenn9541 added 2 commits August 7, 2024 13:32

Add item_type to kmsKeyNames array.

0a04792

Merge branch 'GoogleCloudPlatform:main' into main

7865541

modular-magician added the service/spanner label Aug 7, 2024

c2thorn requested changes Aug 7, 2024

View reviewed changes

mmv1/third_party/terraform/services/spanner/resource_spanner_database_test.go.erb Outdated Show resolved Hide resolved

github-actions bot requested a review from c2thorn August 7, 2024 21:50

c2thorn requested changes Aug 7, 2024

View reviewed changes

panerorenn9541 added 2 commits August 8, 2024 17:13

Remove quotations from key names in resource_spanner_database_test.go…

8687ccc

….erb

Merge branch 'GoogleCloudPlatform:main' into main

8b8764a

github-actions bot requested a review from c2thorn August 9, 2024 00:14

Update permadiff.md

37586d6

Use spaces rather than tabs

github-actions bot requested a review from melinath October 10, 2024 23:54

panerorenn9541 and others added 3 commits October 10, 2024 17:11

Update permadiff.md

5795610

Use spaces instead of tabs

Update Database.yaml

084a6a0

Change description of kmsKeyNames to use plurals

Update mmv1/templates/terraform/custom_flatten/spanner_database_kms_k…

0c0c9e5

…ey_names.go.tmpl Clarify comment Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

Update spanner_database_kms_key_names.go.tmpl

b416e1d

Use spaces instead of tabs

Update resource_spanner_database_test.go.tmpl

e2144b4

Use BootstrapKMSKey instead of crypto keys because crypto keys can't be deleted

ScottSuarez approved these changes Oct 11, 2024

View reviewed changes

ScottSuarez reviewed Oct 11, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spanner MR CMEK Integration #11319

Spanner MR CMEK Integration #11319

panerorenn9541 commented Aug 1, 2024 •

edited

Loading

rahul2393 left a comment

github-actions bot commented Aug 7, 2024

modular-magician commented Aug 7, 2024

modular-magician commented Aug 7, 2024

modular-magician commented Aug 7, 2024

modular-magician commented Aug 7, 2024

c2thorn left a comment

panerorenn9541 commented Aug 7, 2024

c2thorn left a comment

panerorenn9541 commented Aug 9, 2024

modular-magician commented Aug 9, 2024

modular-magician commented Aug 9, 2024

modular-magician commented Oct 11, 2024

modular-magician commented Oct 11, 2024

modular-magician commented Oct 11, 2024

modular-magician commented Oct 11, 2024

modular-magician commented Oct 11, 2024

modular-magician commented Oct 11, 2024

modular-magician commented Oct 11, 2024

modular-magician commented Oct 11, 2024

modular-magician commented Oct 11, 2024

modular-magician commented Oct 11, 2024

modular-magician commented Oct 11, 2024

modular-magician commented Oct 11, 2024

modular-magician commented Oct 11, 2024

modular-magician commented Oct 11, 2024

modular-magician commented Oct 11, 2024

modular-magician commented Oct 11, 2024

modular-magician commented Oct 11, 2024

modular-magician commented Oct 11, 2024

ScottSuarez Oct 11, 2024

Spanner MR CMEK Integration #11319

Are you sure you want to change the base?

Spanner MR CMEK Integration #11319

Conversation

panerorenn9541 commented Aug 1, 2024 • edited Loading

rahul2393 left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 7, 2024

modular-magician commented Aug 7, 2024

Diff report

modular-magician commented Aug 7, 2024

Diff report

modular-magician commented Aug 7, 2024

Tests analytics

modular-magician commented Aug 7, 2024

Tests analytics

c2thorn left a comment

Choose a reason for hiding this comment

panerorenn9541 commented Aug 7, 2024

c2thorn left a comment

Choose a reason for hiding this comment

panerorenn9541 commented Aug 9, 2024

modular-magician commented Aug 9, 2024

Diff report

modular-magician commented Aug 9, 2024

Diff report

modular-magician commented Oct 11, 2024

Diff report

modular-magician commented Oct 11, 2024

Diff report

modular-magician commented Oct 11, 2024

Diff report

modular-magician commented Oct 11, 2024

Diff report

modular-magician commented Oct 11, 2024

Diff report

modular-magician commented Oct 11, 2024

Tests analytics

Action taken

modular-magician commented Oct 11, 2024

modular-magician commented Oct 11, 2024

Diff report

modular-magician commented Oct 11, 2024

Tests analytics

Action taken

modular-magician commented Oct 11, 2024

Tests analytics

Action taken

modular-magician commented Oct 11, 2024

modular-magician commented Oct 11, 2024

modular-magician commented Oct 11, 2024

Tests analytics

Action taken

modular-magician commented Oct 11, 2024

Tests analytics

Action taken

modular-magician commented Oct 11, 2024

modular-magician commented Oct 11, 2024

modular-magician commented Oct 11, 2024

Tests analytics

Action taken

modular-magician commented Oct 11, 2024

ScottSuarez Oct 11, 2024

Choose a reason for hiding this comment

panerorenn9541 commented Aug 1, 2024 •

edited

Loading