Migrate google_compute_firewall_policy_rule resource from DCL to MMv1 #11360

Samir-Cit · 2024-08-05T20:15:03Z

Hello folks.
This PR is to move the Firewall Policy Rule (google_compute_firewall_policy_rule) resource from DCL to MMv1. And this PR includes:

Creation of the resource on MMv1.
Creation of the examples and tests.
Remove references to DCL resource.

Note: This PR doesn't include the deletion of the DCL resource. This change will be done on the Delarative Resource Client Library repository.

Release Note Template for Downstream PRs (will be copied)

compute: `google_compute_firewall_policy_rule` now uses MMv1 engine instead of DCL.

github-actions · 2024-08-09T22:19:23Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2024-08-09T23:28:07Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1110 insertions(+), 594 deletions(-))
google-beta provider: Diff ( 5 files changed, 1110 insertions(+), 594 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 428 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field kind within resource google_compute_firewall_policy_rule was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_firewall_policy_rule (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_firewall_policy_rule" "primary" {
  match {
    src_secure_tags {
      name = # value needed
    }
  }
  rule_name = # value needed
  target_secure_tags {
    name = # value needed
  }
  tls_inspect = # value needed
}

Errors

google provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician · 2024-08-09T23:44:01Z

Tests analytics

Total tests: 979
Passed tests: 903
Skipped tests: 72
Affected tests: 4

Click here to see the affected service packages

compute

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeFirewallPolicyRule_firewallPolicyRuleExample

TestAccComputeFirewallPolicyRule_multipleRules

TestAccComputeFirewallPolicyRule_securityProfileGroup_update

TestAccComputeFirewallPolicyRule_update

Get to know how VCR tests work

modular-magician · 2024-08-09T23:46:14Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeFirewallPolicyRule_firewallPolicyRuleExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_securityProfileGroup_update[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

mmv1/products/compute/FirewallPolicyRule.yaml

modular-magician · 2024-08-12T16:41:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1110 insertions(+), 594 deletions(-))
google-beta provider: Diff ( 5 files changed, 1110 insertions(+), 594 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 428 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field kind within resource google_compute_firewall_policy_rule was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_firewall_policy_rule (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_firewall_policy_rule" "primary" {
  match {
    src_secure_tags {
      name = # value needed
    }
  }
  rule_name = # value needed
  target_secure_tags {
    name = # value needed
  }
  tls_inspect = # value needed
}

Errors

google provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician · 2024-08-12T17:00:02Z

Tests analytics

Total tests: 979
Passed tests: 902
Skipped tests: 72
Affected tests: 5

Click here to see the affected service packages

compute

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeFirewallPolicyRule_firewallPolicyRuleExample

TestAccComputeFirewallPolicyRule_multipleRules

TestAccComputeFirewallPolicyRule_securityProfileGroup_update

TestAccComputeFirewallPolicyRule_update

TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

Get to know how VCR tests work

modular-magician · 2024-08-12T17:07:43Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeFirewallPolicyRule_firewallPolicyRuleExample[Debug log]
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_securityProfileGroup_update[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician · 2024-08-14T00:56:38Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1123 insertions(+), 597 deletions(-))
google-beta provider: Diff ( 5 files changed, 1123 insertions(+), 597 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 428 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field kind within resource google_compute_firewall_policy_rule was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_firewall_policy_rule (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_firewall_policy_rule" "primary" {
  match {
    src_secure_tags {
      name = # value needed
    }
  }
  rule_name = # value needed
  target_secure_tags {
    name = # value needed
  }
  tls_inspect = # value needed
}

Errors

google provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician · 2024-08-14T01:11:46Z

Tests analytics

Total tests: 980
Passed tests: 902
Skipped tests: 72
Affected tests: 6

Click here to see the affected service packages

compute

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeDisk_storagePoolSpecified

TestAccComputeFirewallPolicyRule_firewallPolicyRuleExample

TestAccComputeFirewallPolicyRule_multipleRules

TestAccComputeFirewallPolicyRule_securityProfileGroup_update

TestAccComputeFirewallPolicyRule_update

TestAccComputeInstance_bootDisk_storagePoolSpecified

Get to know how VCR tests work

modular-magician · 2024-08-14T01:16:30Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeFirewallPolicyRule_firewallPolicyRuleExample[Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Debug log]
TestAccComputeFirewallPolicyRule_securityProfileGroup_update[Debug log]
TestAccComputeFirewallPolicyRule_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeDisk_storagePoolSpecified[Error message] [Debug log]
TestAccComputeInstance_bootDisk_storagePoolSpecified[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

github-actions · 2024-08-15T09:40:54Z

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

BBBmau · 2024-08-15T16:30:42Z

/gcbrun

github-actions · 2024-08-19T09:40:49Z

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Samir-Cit · 2024-08-21T14:37:35Z

/gcbrun

@BBBmau this command is working?
Looks like it didn't execute any check.

modular-magician · 2024-08-21T15:16:06Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1123 insertions(+), 597 deletions(-))
google-beta provider: Diff ( 5 files changed, 1123 insertions(+), 597 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 428 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field kind within resource google_compute_firewall_policy_rule was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_firewall_policy_rule (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_firewall_policy_rule" "primary" {
  match {
    src_secure_tags {
      name = # value needed
    }
  }
  rule_name = # value needed
  target_secure_tags {
    name = # value needed
  }
  tls_inspect = # value needed
}

Errors

google provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician · 2024-09-17T23:27:27Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 253 insertions(+), 221 deletions(-))
google-beta provider: Diff ( 6 files changed, 995 insertions(+), 611 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 331 insertions(+))

modular-magician · 2024-09-17T23:44:31Z

Tests analytics

Total tests: 1006
Passed tests: 930
Skipped tests: 74
Affected tests: 2

Click here to see the affected service packages

compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeFirewallPolicyRule_basic

TestAccComputeFirewallPolicyRule_firewallPolicyRuleExample

Get to know how VCR tests work

modular-magician · 2024-09-17T23:47:10Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeFirewallPolicyRule_basic[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeFirewallPolicyRule_firewallPolicyRuleExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

github-actions · 2024-09-20T09:42:59Z

@BBBmau @trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2024-09-24T09:41:53Z

@GoogleCloudPlatform/terraform-team @BBBmau @trodge This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

c2thorn · 2024-09-25T20:00:14Z

Confirming that I have spoken with @Samir-Cit offline and received permission to force push to this branch

Resource

trodge · 2024-09-27T21:41:22Z

Backup located here

modular-magician · 2024-09-27T21:59:02Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 979 insertions(+), 613 deletions(-))
google-beta provider: Diff ( 6 files changed, 979 insertions(+), 613 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 331 insertions(+))

Errors

google provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician · 2024-09-27T22:16:06Z

Tests analytics

Total tests: 1018
Passed tests: 863
Skipped tests: 74
Affected tests: 81

Click here to see the affected service packages

compute

Action taken

Found 81 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeFirewallPolicyRule_firewallPolicyRuleExample

TestAccComputeInstanceConfidentialInstanceConfigMain

TestAccComputeInstanceFromMachineImageWithOverride_localSsdRecoveryTimeout

TestAccComputeInstanceFromMachineImageWithOverride_partnerMetadata

TestAccComputeInstanceFromMachineImage_basic

TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain

TestAccComputeInstanceFromMachineImage_diffProject

TestAccComputeInstanceFromMachineImage_localSsdRecoveryTimeout

TestAccComputeInstanceFromMachineImage_maxRunDuration

TestAccComputeInstanceFromRegionTemplate_basic

TestAccComputeInstanceFromTemplateWithOverride_localSsdRecoveryTimeout

TestAccComputeInstanceFromTemplateWithOverride_partnerMetadata

TestAccComputeInstanceFromTemplate_basic

TestAccComputeInstanceFromTemplate_confidentialInstanceConfigMain

TestAccComputeInstanceFromTemplate_localSsdRecoveryTimeout

TestAccComputeInstanceFromTemplate_maxRunDuration_onInstanceStopAction

TestAccComputeInstanceFromTemplate_overrideScheduling

TestAccComputeInstanceFromTemplate_partnerMetadata

TestAccComputeInstanceFromTemplate_self_link_unique

TestAccComputeInstanceTemplate_AdvancedMachineFeatures

TestAccComputeInstanceTemplate_ConfidentialInstanceConfigMain

TestAccComputeInstanceTemplate_basic

TestAccComputeInstanceTemplate_guestAccelerator

TestAccComputeInstanceTemplate_guestAcceleratorSkip

TestAccComputeInstanceTemplate_imageShorthand

TestAccComputeInstanceTemplate_instanceResourcePolicies

TestAccComputeInstanceTemplate_localSsdRecoveryTimeout

TestAccComputeInstanceTemplate_maintenance_interval

TestAccComputeInstanceTemplate_managedEnvoy

TestAccComputeInstanceTemplate_maxRunDuration_onInstanceStopAction

TestAccComputeInstanceTemplate_minCpuPlatform

TestAccComputeInstanceTemplate_nictype_update

TestAccComputeInstanceTemplate_preemptible

TestAccComputeInstanceTemplate_soleTenantNodeAffinities

TestAccComputeInstanceTemplate_spot

TestAccComputeInstanceTemplate_spot_maxRunDuration

TestAccComputeInstanceTemplate_spot_maxRunDuration_deleteTerminationAction

TestAccComputeInstanceTemplate_spot_maxRunDuration_stopTerminationAction

TestAccComputeInstance_guestAccelerator

TestAccComputeInstance_guestAcceleratorSkip

TestAccComputeInstance_localSsdRecoveryTimeout

TestAccComputeInstance_localSsdRecoveryTimeout_update

TestAccComputeInstance_localSsdVM_maxRunDuration_stopTerminationAction

TestAccComputeInstance_maxRunDuration_update

TestAccComputeInstance_resourcePolicyCollocate

TestAccComputeInstance_scheduling

TestAccComputeInstance_soleTenantNodeAffinities

TestAccComputeInstance_spotVM

TestAccComputeInstance_spotVM_maxRunDuration_deleteTerminationAction

TestAccComputeInstance_spotVM_maxRunDuration_update

TestAccComputeInstance_spotVM_update

TestAccComputeInstance_standardVM_maxRunDuration_deleteTerminationAction

TestAccComputeInstance_standardVM_maxRunDuration_stopTerminationAction

TestAccComputeInterconnectAttachment_interconnectAttachmentDedicatedExample

TestAccComputeRegionInstanceTemplate_AdvancedMachineFeatures

TestAccComputeRegionInstanceTemplate_ConfidentialInstanceConfigMain

TestAccComputeRegionInstanceTemplate_basic

TestAccComputeRegionInstanceTemplate_guestAccelerator

TestAccComputeRegionInstanceTemplate_guestAcceleratorSkip

TestAccComputeRegionInstanceTemplate_imageShorthand

TestAccComputeRegionInstanceTemplate_instanceResourcePolicies

TestAccComputeRegionInstanceTemplate_localSsdRecoveryTimeout

TestAccComputeRegionInstanceTemplate_maintenance_interval

TestAccComputeRegionInstanceTemplate_managedEnvoy

TestAccComputeRegionInstanceTemplate_maxRunDuration_onInstanceStopAction

TestAccComputeRegionInstanceTemplate_minCpuPlatform

TestAccComputeRegionInstanceTemplate_nictype_update

TestAccComputeRegionInstanceTemplate_preemptible

TestAccComputeRegionInstanceTemplate_soleTenantNodeAffinities

TestAccComputeRegionInstanceTemplate_spot

TestAccComputeRegionInstanceTemplate_spot_maxRunDuration

TestAccComputeResizeRequest_computeMigResizeRequestExample

TestAccComputeRouterNat_AutoNetworkTier

TestAccComputeRouterNat_update

TestAccComputeRouterNat_withManualIpAndSubnetConfiguration

TestAccComputeRouterNat_withNatIpsAndDrainNatIps

TestAccComputeRouterNat_withNatRules

TestAccComputeRouterNat_withPortAllocationMethods

TestAccComputeRouterNat_withPrivateNatAndEmptyAction

TestAccComputeRouterNat_withPrivateNatAndEmptyActionActiveRanges

TestAccComputeRouterNat_withPrivateNatAndRules

Get to know how VCR tests work

modular-magician · 2024-09-27T22:34:41Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeInstanceConfidentialInstanceConfigMain[Debug log]
TestAccComputeInstanceFromMachineImageWithOverride_localSsdRecoveryTimeout[Debug log]
TestAccComputeInstanceFromMachineImageWithOverride_partnerMetadata[Debug log]
TestAccComputeInstanceFromMachineImage_basic[Debug log]
TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain[Debug log]
TestAccComputeInstanceFromMachineImage_diffProject[Debug log]
TestAccComputeInstanceFromMachineImage_localSsdRecoveryTimeout[Debug log]
TestAccComputeInstanceFromMachineImage_maxRunDuration[Debug log]
TestAccComputeInstanceFromRegionTemplate_basic[Debug log]
TestAccComputeInstanceFromTemplateWithOverride_localSsdRecoveryTimeout[Debug log]
TestAccComputeInstanceFromTemplateWithOverride_partnerMetadata[Debug log]
TestAccComputeInstanceFromTemplate_basic[Debug log]
TestAccComputeInstanceFromTemplate_confidentialInstanceConfigMain[Debug log]
TestAccComputeInstanceFromTemplate_localSsdRecoveryTimeout[Debug log]
TestAccComputeInstanceFromTemplate_maxRunDuration_onInstanceStopAction[Debug log]
TestAccComputeInstanceFromTemplate_overrideScheduling[Debug log]
TestAccComputeInstanceFromTemplate_partnerMetadata[Debug log]
TestAccComputeInstanceFromTemplate_self_link_unique[Debug log]
TestAccComputeInstanceTemplate_AdvancedMachineFeatures[Debug log]
TestAccComputeInstanceTemplate_ConfidentialInstanceConfigMain[Debug log]
TestAccComputeInstanceTemplate_basic[Debug log]
TestAccComputeInstanceTemplate_guestAccelerator[Debug log]
TestAccComputeInstanceTemplate_guestAcceleratorSkip[Debug log]
TestAccComputeInstanceTemplate_instanceResourcePolicies[Debug log]
TestAccComputeInstanceTemplate_localSsdRecoveryTimeout[Debug log]
TestAccComputeInstanceTemplate_maintenance_interval[Debug log]
TestAccComputeInstanceTemplate_managedEnvoy[Debug log]
TestAccComputeInstanceTemplate_maxRunDuration_onInstanceStopAction[Debug log]
TestAccComputeInstanceTemplate_minCpuPlatform[Debug log]
TestAccComputeInstanceTemplate_preemptible[Debug log]
TestAccComputeInstanceTemplate_soleTenantNodeAffinities[Debug log]
TestAccComputeInstanceTemplate_spot[Debug log]
TestAccComputeInstanceTemplate_spot_maxRunDuration[Debug log]
TestAccComputeInstanceTemplate_spot_maxRunDuration_deleteTerminationAction[Debug log]
TestAccComputeInstanceTemplate_spot_maxRunDuration_stopTerminationAction[Debug log]
TestAccComputeInstance_guestAccelerator[Debug log]
TestAccComputeInstance_guestAcceleratorSkip[Debug log]
TestAccComputeInstance_localSsdRecoveryTimeout[Debug log]
TestAccComputeInstance_localSsdRecoveryTimeout_update[Debug log]
TestAccComputeInstance_localSsdVM_maxRunDuration_stopTerminationAction[Debug log]
TestAccComputeInstance_maxRunDuration_update[Debug log]
TestAccComputeInstance_resourcePolicyCollocate[Debug log]
TestAccComputeInstance_scheduling[Debug log]
TestAccComputeInstance_soleTenantNodeAffinities[Debug log]
TestAccComputeInstance_spotVM[Debug log]
TestAccComputeInstance_spotVM_maxRunDuration_deleteTerminationAction[Debug log]
TestAccComputeInstance_spotVM_maxRunDuration_update[Debug log]
TestAccComputeInstance_spotVM_update[Debug log]
TestAccComputeInstance_standardVM_maxRunDuration_deleteTerminationAction[Debug log]
TestAccComputeInstance_standardVM_maxRunDuration_stopTerminationAction[Debug log]
TestAccComputeInterconnectAttachment_interconnectAttachmentDedicatedExample[Debug log]
TestAccComputeRegionInstanceTemplate_AdvancedMachineFeatures[Debug log]
TestAccComputeRegionInstanceTemplate_ConfidentialInstanceConfigMain[Debug log]
TestAccComputeRegionInstanceTemplate_basic[Debug log]
TestAccComputeRegionInstanceTemplate_guestAccelerator[Debug log]
TestAccComputeRegionInstanceTemplate_guestAcceleratorSkip[Debug log]
TestAccComputeRegionInstanceTemplate_instanceResourcePolicies[Debug log]
TestAccComputeRegionInstanceTemplate_localSsdRecoveryTimeout[Debug log]
TestAccComputeRegionInstanceTemplate_maintenance_interval[Debug log]
TestAccComputeRegionInstanceTemplate_managedEnvoy[Debug log]
TestAccComputeRegionInstanceTemplate_maxRunDuration_onInstanceStopAction[Debug log]
TestAccComputeRegionInstanceTemplate_minCpuPlatform[Debug log]
TestAccComputeRegionInstanceTemplate_preemptible[Debug log]
TestAccComputeRegionInstanceTemplate_soleTenantNodeAffinities[Debug log]
TestAccComputeRegionInstanceTemplate_spot[Debug log]
TestAccComputeRegionInstanceTemplate_spot_maxRunDuration[Debug log]
TestAccComputeResizeRequest_computeMigResizeRequestExample[Debug log]
TestAccComputeRouterNat_AutoNetworkTier[Debug log]
TestAccComputeRouterNat_update[Debug log]
TestAccComputeRouterNat_withManualIpAndSubnetConfiguration[Debug log]
TestAccComputeRouterNat_withNatIpsAndDrainNatIps[Debug log]
TestAccComputeRouterNat_withNatRules[Debug log]
TestAccComputeRouterNat_withPortAllocationMethods[Debug log]
TestAccComputeRouterNat_withPrivateNatAndEmptyAction[Debug log]
TestAccComputeRouterNat_withPrivateNatAndEmptyActionActiveRanges[Debug log]
TestAccComputeRouterNat_withPrivateNatAndRules[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeFirewallPolicyRule_firewallPolicyRuleExample[Error message] [Debug log]
TestAccComputeInstanceTemplate_imageShorthand[Error message] [Debug log]
TestAccComputeInstanceTemplate_nictype_update[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_imageShorthand[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_nictype_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

add deletion_protection = false

modular-magician · 2024-09-27T23:21:51Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 981 insertions(+), 613 deletions(-))
google-beta provider: Diff ( 6 files changed, 981 insertions(+), 613 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 331 insertions(+))

Errors

google provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician · 2024-09-27T23:41:41Z

Tests analytics

Total tests: 1018
Passed tests: 940
Skipped tests: 74
Affected tests: 4

Click here to see the affected service packages

compute

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInstanceTemplate_imageShorthand

TestAccComputeInstanceTemplate_nictype_update

TestAccComputeRegionInstanceTemplate_imageShorthand

TestAccComputeRegionInstanceTemplate_nictype_update

Get to know how VCR tests work

modular-magician · 2024-09-27T23:41:59Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceTemplate_imageShorthand[Error message] [Debug log]
TestAccComputeInstanceTemplate_nictype_update[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_imageShorthand[Error message] [Debug log]
TestAccComputeRegionInstanceTemplate_nictype_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

github-actions · 2024-10-01T09:42:12Z

@GoogleCloudPlatform/terraform-team @BBBmau @trodge This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2024-10-08T09:42:27Z

@GoogleCloudPlatform/terraform-team @BBBmau @trodge This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Aug 5, 2024

Samir-Cit changed the title ~~Move google_compute_firewall_policy_ruleresource from DCL to MMv1~~ Move google_compute_firewall_policy_rule resource from DCL to MMv1 Aug 5, 2024

Samir-Cit marked this pull request as ready for review August 9, 2024 22:18

github-actions bot requested a review from BBBmau August 9, 2024 22:19

modular-magician added service/network-security-distributed-firewall and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Aug 9, 2024

BBBmau reviewed Aug 10, 2024

View reviewed changes

mmv1/products/compute/FirewallPolicyRule.yaml Outdated Show resolved Hide resolved

github-actions bot requested a review from BBBmau August 12, 2024 15:57

modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Aug 12, 2024

modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Aug 13, 2024

modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Aug 15, 2024

Samir-Cit changed the title ~~Move google_compute_firewall_policy_rule resource from DCL to MMv1~~ Migrate google_compute_firewall_policy_rule resource from DCL to MMv1 Aug 19, 2024

modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Aug 21, 2024

modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Sep 17, 2024

modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Sep 18, 2024

c2thorn added the not-go-migrated label Sep 24, 2024

trodge force-pushed the feat/FirewallPolicyRule branch 2 times, most recently from 03b8198 to 33c706c Compare September 27, 2024 21:30

trodge added 2 commits September 27, 2024 14:38

Convert from Ruby to Go

1ce5de6

Resource

Remove overrides

de43914

trodge force-pushed the feat/FirewallPolicyRule branch from 33c706c to de43914 Compare September 27, 2024 21:40

trodge removed the not-go-migrated label Sep 27, 2024

modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Sep 27, 2024

Update firewall_policy_rule.tf.tmpl

7b9d5c5

add deletion_protection = false

modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Sep 27, 2024

Samir-Cit marked this pull request as draft October 8, 2024 22:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate google_compute_firewall_policy_rule resource from DCL to MMv1 #11360

Migrate google_compute_firewall_policy_rule resource from DCL to MMv1 #11360

Samir-Cit commented Aug 5, 2024 •

edited

Loading

github-actions bot commented Aug 9, 2024

modular-magician commented Aug 9, 2024

modular-magician commented Aug 9, 2024

modular-magician commented Aug 9, 2024

modular-magician commented Aug 12, 2024

modular-magician commented Aug 12, 2024

modular-magician commented Aug 12, 2024

modular-magician commented Aug 14, 2024

modular-magician commented Aug 14, 2024

modular-magician commented Aug 14, 2024

github-actions bot commented Aug 15, 2024

BBBmau commented Aug 15, 2024

github-actions bot commented Aug 19, 2024

Samir-Cit commented Aug 21, 2024

modular-magician commented Aug 21, 2024

modular-magician commented Sep 17, 2024

modular-magician commented Sep 17, 2024

modular-magician commented Sep 17, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 24, 2024

c2thorn commented Sep 25, 2024

trodge commented Sep 27, 2024

modular-magician commented Sep 27, 2024

modular-magician commented Sep 27, 2024

modular-magician commented Sep 27, 2024

modular-magician commented Sep 27, 2024

modular-magician commented Sep 27, 2024

modular-magician commented Sep 27, 2024

github-actions bot commented Oct 1, 2024

github-actions bot commented Oct 8, 2024

Migrate google_compute_firewall_policy_rule resource from DCL to MMv1 #11360

Are you sure you want to change the base?

Migrate google_compute_firewall_policy_rule resource from DCL to MMv1 #11360

Conversation

Samir-Cit commented Aug 5, 2024 • edited Loading

github-actions bot commented Aug 9, 2024

modular-magician commented Aug 9, 2024

Diff report

Breaking Change(s) Detected

Missing test report

Errors

modular-magician commented Aug 9, 2024

Tests analytics

Action taken

modular-magician commented Aug 9, 2024

modular-magician commented Aug 12, 2024

Diff report

Breaking Change(s) Detected

Missing test report

Errors

modular-magician commented Aug 12, 2024

Tests analytics

Action taken

modular-magician commented Aug 12, 2024

modular-magician commented Aug 14, 2024

Diff report

Breaking Change(s) Detected

Missing test report

Errors

modular-magician commented Aug 14, 2024

Tests analytics

Action taken

modular-magician commented Aug 14, 2024

github-actions bot commented Aug 15, 2024

BBBmau commented Aug 15, 2024

github-actions bot commented Aug 19, 2024

Samir-Cit commented Aug 21, 2024

modular-magician commented Aug 21, 2024

Diff report

Breaking Change(s) Detected

Missing test report

Errors

modular-magician commented Sep 17, 2024

Diff report

modular-magician commented Sep 17, 2024

Tests analytics

Action taken

modular-magician commented Sep 17, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 24, 2024

c2thorn commented Sep 25, 2024

trodge commented Sep 27, 2024

modular-magician commented Sep 27, 2024

Diff report

Errors

modular-magician commented Sep 27, 2024

Tests analytics

Action taken

modular-magician commented Sep 27, 2024

modular-magician commented Sep 27, 2024

Diff report

Errors

modular-magician commented Sep 27, 2024

Tests analytics

Action taken

modular-magician commented Sep 27, 2024

github-actions bot commented Oct 1, 2024

github-actions bot commented Oct 8, 2024

Samir-Cit commented Aug 5, 2024 •

edited

Loading