-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate google_compute_firewall_policy_rule resource from DCL to MMv1 #11360
base: main
Are you sure you want to change the base?
Migrate google_compute_firewall_policy_rule resource from DCL to MMv1 #11360
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_firewall_policy_rule" "primary" {
match {
src_secure_tags {
name = # value needed
}
}
rule_name = # value needed
target_secure_tags {
name = # value needed
}
tls_inspect = # value needed
}
Errors
|
Tests analyticsTotal tests: 979 Click here to see the affected service packages
Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_firewall_policy_rule" "primary" {
match {
src_secure_tags {
name = # value needed
}
}
rule_name = # value needed
target_secure_tags {
name = # value needed
}
tls_inspect = # value needed
}
Errors
|
Tests analyticsTotal tests: 979 Click here to see the affected service packages
Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_firewall_policy_rule" "primary" {
match {
src_secure_tags {
name = # value needed
}
}
rule_name = # value needed
target_secure_tags {
name = # value needed
}
tls_inspect = # value needed
}
Errors
|
Tests analyticsTotal tests: 980 Click here to see the affected service packages
Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
/gcbrun |
@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label |
@BBBmau this command is working? |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_firewall_policy_rule" "primary" {
match {
src_secure_tags {
name = # value needed
}
}
rule_name = # value needed
target_secure_tags {
name = # value needed
}
tls_inspect = # value needed
}
Errors
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1006 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Confirming that I have spoken with @Samir-Cit offline and received permission to force push to this branch |
03b8198
to
33c706c
Compare
33c706c
to
de43914
Compare
Backup located here |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Tests analyticsTotal tests: 1018 Click here to see the affected service packages
Action takenFound 81 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
add deletion_protection = false
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Tests analyticsTotal tests: 1018 Click here to see the affected service packages
Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Hello folks.
This PR is to move the Firewall Policy Rule (
google_compute_firewall_policy_rule
) resource from DCL to MMv1. And this PR includes:Note: This PR doesn't include the deletion of the DCL resource. This change will be done on the Delarative Resource Client Library repository.
Release Note Template for Downstream PRs (will be copied)