Promote Firestore database cmek support to GA

[jinyangtang]

Promote Firestore database cmek support to GA:

• Adds the new field cmek_config to google_firestore_database to support creating a Firestore CMEK database.

Self check:

• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).

Release Note Template for Downstream PRs (will be copied)

firestore: added `cmek_config` field to `google_firestore_database` resource (GA)

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 257 insertions(+), 19 deletions(-))
google-beta provider: Diff ( 2 files changed, 3 insertions(+), 39 deletions(-))

[modular-magician]

Tests analytics

Total tests: 20
Passed tests: 20
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• firestore

#### Non-exercised tests

Tests were added that are GA-only additions and require manual runs:

• TestAccFirestoreDatabase_firestoreCmekDatabaseExample
• TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample
  $\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[jinyangtang]

Hi @trodge Could you please help to review my PR to promote Firestore cmek support for Terraform to GA branch please? Thank you!

[trodge]

Hi @trodge Could you please help to review my PR to promote Firestore cmek support for Terraform to GA branch please? Thank you!

Taking a look at it now. Would it be possible for you to share test logs with me for the GA run of TestAccFirestoreDatabase_firestoreCmekDatabaseExample and TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample? Our automated testing for PRs currently only covers beta.

[jinyangtang]

Hi @trodge Could you please help to review my PR to promote Firestore cmek support for Terraform to GA branch please? Thank you!

Taking a look at it now. Would it be possible for you to share test logs with me for the GA run of TestAccFirestoreDatabase_firestoreCmekDatabaseExample and TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample? Our automated testing for PRs currently only covers beta.

Sure! Here is the test log:

• TestAccFirestoreDatabase_firestoreCmekDatabaseExample: http://gpaste/6033865150038016
• TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample: http://gpaste/5390771442417664

[github-actions]

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[trodge]

Hi @trodge Could you please help to review my PR to promote Firestore cmek support for Terraform to GA branch please? Thank you!

Taking a look at it now. Would it be possible for you to share test logs with me for the GA run of TestAccFirestoreDatabase_firestoreCmekDatabaseExample and TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample? Our automated testing for PRs currently only covers beta.

Sure! Here is the test log:

• TestAccFirestoreDatabase_firestoreCmekDatabaseExample: http://gpaste/6033865150038016
• TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample: http://gpaste/5390771442417664

From searching the logs I wasn't able to find any POST requests to the firestore API? Is that expected?

Normally I'd expect the test for an immutable field to create and then destroy the resource.

[jinyangtang]

Hi @trodge Could you please help to review my PR to promote Firestore cmek support for Terraform to GA branch please? Thank you!

Taking a look at it now. Would it be possible for you to share test logs with me for the GA run of TestAccFirestoreDatabase_firestoreCmekDatabaseExample and TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample? Our automated testing for PRs currently only covers beta.

Sure! Here is the test log:

• TestAccFirestoreDatabase_firestoreCmekDatabaseExample: http://gpaste/6033865150038016
• TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample: http://gpaste/5390771442417664

From searching the logs I wasn't able to find any POST requests to the firestore API? Is that expected?

Normally I'd expect the test for an immutable field to create and then destroy the resource.

Oh sorry some of the log output has been cut, here's the POST request where it tried to create CMEK database:

• TestAccFirestoreDatabase_firestoreCmekDatabaseExample: http://gpaste/4739548469002240#l=21
• TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample: http://gpaste/5952847520989184
  (The difference between these two CMEK database creation is the former is creating a type Firestore_native, the latter is creating type datastore_mode)