Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mentions of conditions support from google_bigquery_table_iam #11405

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

wj-chen
Copy link
Member

@wj-chen wj-chen commented Aug 8, 2024

Fixes hashicorp/terraform-provider-google#18645.

Release Note Template for Downstream PRs (will be copied)


Copy link

github-actions bot commented Aug 8, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 6 insertions(+), 714 deletions(-))
google-beta provider: Diff ( 3 files changed, 6 insertions(+), 714 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 5 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 114
Passed tests: 101
Skipped tests: 10
Affected tests: 3

Click here to see the affected service packages
  • bigquery

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBigQueryTableIamBindingGenerated
  • TestAccBigQueryTableIamMemberGenerated
  • TestAccBigQueryTableIamPolicyGenerated

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigQueryTableIamBindingGenerated[Debug log]
TestAccBigQueryTableIamMemberGenerated[Debug log]
TestAccBigQueryTableIamPolicyGenerated[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

Copy link

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@wj-chen
Copy link
Member Author

wj-chen commented Aug 15, 2024

@NickElliot Could you take a look?

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified lack of ability to apply conditions, diffs are removing tests and docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigqueryTableIamMember doesn't support IAM conditions
3 participants