Fix metadata drifting on workbench instances

[bcreddy-gcp]

fixes hashicorp/terraform-provider-google#18827

Release Note Template for Downstream PRs (will be copied)

workbench: fixed a bug with workbench instance metadata drifting when using custom containers.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 3 insertions(+))
google-beta provider: Diff ( 1 file changed, 3 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 3 insertions(+))

[modular-magician]

Tests analytics

Total tests: 20
Passed tests: 20
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• workbench

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[c2thorn]

is there an associated github issue and/or bug? Is this scenario covered by tests / how was this tested?

[bcreddy-gcp]

b/357693909
hashicorp/terraform-provider-google#18827.

[bcreddy-gcp]

Similar PR: #10900

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 3 insertions(+))
google-beta provider: Diff ( 1 file changed, 3 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 3 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 3 insertions(+))
google-beta provider: Diff ( 1 file changed, 3 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 3 insertions(+))

[modular-magician]

Tests analytics

Total tests: 20
Passed tests: 20
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• workbench

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[modular-magician]

Tests analytics

Total tests: 20
Passed tests: 20
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• workbench

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 3 insertions(+))
google-beta provider: Diff ( 1 file changed, 3 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 3 insertions(+))

[modular-magician]

Tests analytics

Total tests: 20
Passed tests: 20
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• workbench

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log