Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore trace_id in the request #11408

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

lola98
Copy link
Contributor

@lola98 lola98 commented Aug 9, 2024

When updating any existing quota_preference object, ignore the associated trace_id .

Release Note Template for Downstream PRs (will be copied)


Copy link

github-actions bot commented Aug 9, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from trodge August 9, 2024 00:34
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 114 insertions(+), 112 deletions(-))
google-beta provider: Diff ( 2 files changed, 114 insertions(+), 112 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3
Passed tests: 3
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • cloudquotas

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3
Passed tests: 3
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • cloudquotas

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@trodge
Copy link
Contributor

trodge commented Aug 9, 2024

Is there an issue you can link to that has more context on why this change is needed?

@lola98
Copy link
Contributor Author

lola98 commented Aug 9, 2024

Is there an issue you can link to that has more context on why this change is needed?

Yes https://buganizer.corp.google.com/issues/356922112#comment5 has more context on this. Basically we want to ignore the trace_id field when creating and updating preferences.

@trodge trodge merged commit 5043710 into GoogleCloudPlatform:main Aug 12, 2024
14 checks passed
rainshen49 pushed a commit to rainshen49/magic-modules that referenced this pull request Aug 12, 2024
BBBmau pushed a commit to bschaatsbergen/magic-modules that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants