Enable goog-terraform-provisioned provider label #11439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 3876 Click here to see the affected service packages
Action takenFound 2281 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
got a weird error from |
|
/gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 3880 Click here to see the affected service packages
Action takenFound 2285 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Trying out adding I also considered running the tests with the provider config set to not include the label, but that would mean our acceptance tests would be running in a different environment than most of our users. I'm also open to other suggestions :-) |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
I think this is smart as most references to |
Tests analyticsTotal tests: 3881 Click here to see the affected service packages
Action takenFound 2286 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
This will take a while because it needs to record a bunch of tests. It will probably time out after recording most of them, then we can rerun for the last ones |
|
Once it's confirmed that injecting |
|
/gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 3879 Click here to see the affected service packages
Action takenFound 2284 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Triggered a subset of VCR tests on TC. Let's see if that works https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLEBETA_MODMAGICIAN_VCR/219386?hideTestsFromDependencies=false&hideProblemsFromDependencies=false&expandBuildChangesSection=true see list of testsTestAccComputeAddress_addressBasicExample|TestAccComputeAddress_addressWithGceEndpointExample|TestAccComputeAddress_addressWithSharedLoadbalancerVipExample|TestAccComputeAddress_addressWithSubnetworkExample|TestAccComputeAddress_computeAddressIpsecInterconnectExample|TestAccComputeAddress_instanceWithIpExample|TestAccComputeAddress_internal|TestAccComputeAddress_internalIpv6|TestAccComputeAttachedDisk_basic|TestAccComputeAttachedDisk_count|TestAccComputeAttachedDisk_full|TestAccComputeAttachedDisk_region|TestAccComputeAttachedDisk_zoneless|TestAccComputeAutoscaler_autoscalerBasicExample|TestAccComputeAutoscaler_autoscalerSingleInstanceExample|TestAccComputeAutoscaler_multicondition|TestAccComputeAutoscaler_scaleDownControl|TestAccComputeAutoscaler_scaleInControl|TestAccComputeAutoscaler_scaleInControlFixed|TestAccComputeAutoscaler_scalingSchedule|TestAccComputeAutoscaler_update|TestAccComputeBackendBucketIamBindingGenerated|TestAccComputeBackendBucketIamMemberGenerated|TestAccComputeBackendBucketIamPolicyGenerated|TestAccComputeBackendBucketSignedUrlKey_basic|TestAccComputeBackendBucket_backendBucketBasicExample|TestAccComputeBackendBucket_backendBucketBypassCacheExample|TestAccComputeBackendBucket_backendBucketCoalescingExample|TestAccComputeBackendBucket_backendBucketFullExample|TestAccComputeBackendBucket_backendBucketIncludeHttpHeadersExample|TestAccComputeBackendBucket_backendBucketQueryStringWhitelistExample|TestAccComputeBackendBucket_backendBucketSecurityPolicyExample|TestAccComputeBackendBucket_basicModified|TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample|TestAccComputeBackendBucket_withCdnCacheMode_update|TestAccComputeBackendBucket_withCdnPolicy|TestAccComputeBackendBucket_withCompressionMode|TestAccComputeBackendBucket_withSecurityPolicy|TestAccComputeBackendService_withBackend|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeBackendService_withBackendAndMaxUtilization|TestAccComputeBackendService_withClientTlsPolicy|TestAccComputeBackendService_withMaxConnections|TestAccComputeBackendService_withMaxConnectionsPerEndpoint|TestAccComputeBackendService_withMaxConnectionsPerInstance|TestAccComputeBackendService_withMaxRatePerEndpoint|TestAccComputeDiskAsyncReplication|TestAccComputeDiskIamBindingGenerated|TestAccComputeDiskIamMemberGenerated|TestAccComputeDiskIamPolicyGenerated|TestAccComputeDiskResourcePolicyAttachment_diskResourcePolicyAttachmentBasicExample|TestAccComputeDiskResourcePolicyAttachment_update|TestAccComputeDisk_accessModeSpecified|TestAccComputeDisk_cloneDisk|TestAccComputeDisk_deleteDetach|TestAccComputeDisk_diskAsyncExample|TestAccComputeDisk_diskBasicExample|TestAccComputeDisk_diskFeaturesExample|TestAccComputeDisk_encryption|TestAccComputeDisk_encryptionKMS|TestAccComputeDisk_encryptionWithRSAEncryptedKey|TestAccComputeDisk_featuresUpdated|TestAccComputeDisk_fromSnapshot|TestAccComputeDisk_fromTypeUrl|TestAccComputeDisk_multiWriter|TestAccComputeDisk_pdExtremeImplicitProvisionedIops|TestAccComputeDisk_pdHyperDiskEnableConfidentialCompute|TestAccComputeDisk_pdHyperDiskProvisionedIopsLifeCycle|TestAccComputeDisk_pdHyperDiskProvisionedThroughputLifeCycle|TestAccComputeDisk_resourcePolicies|TestAccComputeDisk_storagePoolSpecified|TestAccComputeDisk_update|TestAccComputeDisk_updateResourcePolicies|TestAccComputeExternalVPNGateway_updateLabels|TestAccComputeExternalVpnGateway_onlyExternalVpnGatewayFullExample|TestAccComputeFirewallPolicyRule_BasicFirSecRuleHandWritten|TestAccComputeFirewallPolicyRule_multipleRules|TestAccComputeFirewallPolicyRule_securityProfileGroup_update|TestAccComputeFirewallPolicyRule_update|TestAccComputeFirewall_moduleOutput|TestAccComputeForwardingRule_forwardingRuleBasicExample|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example|TestAccComputeForwardingRule_forwardingRuleIpAddressIpv6|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputeForwardingRule_forwardingRulePscRecreate|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample|TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate|TestAccComputeForwardingRule_forwardingRuleVpcPscExample|TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate |
Sorry, didn't see the latest change. Cancelled the TC run for now and see if the new test run will work |
SirGitsalot
commented
Aug 15, 2024
| @@ -14,6 +14,7 @@ import ( | |||
| "path/filepath" | |||
| "reflect" | |||
| "regexp" | |||
| "slices" | |||
There was a problem hiding this comment.
Self review: the slices package was added in Go 1.21 - as of this week (1.23 was just released) that's a couple of major versions ago but I though I'd call it out in case it's a problem.
|
whitelist the PR in evil build killer /gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 3884 Click here to see the affected service packages
Action takenFound 2289 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
/gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 3882 Click here to see the affected service packages
Action takenFound 118 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 3897 Click here to see the affected service packages
Action takenFound 64 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 3897 Click here to see the affected service packages
Action takenFound 130 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 3897 Click here to see the affected service packages
Action takenFound 60 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
|
|
@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 1 week. Please take a look! Use the label |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 3897 Click here to see the affected service packages
Action takenFound 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
|
c2thorn
approved these changes
Aug 20, 2024
|
The remaining tests look already failing |
c2thorn
merged commit 0b62ec9
into
FEATURE-BRANCH-major-release-6.0.0
10 of 11 checks passed
This was referenced Aug 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch the
goog-terraform-provisionedlabel added in v5.0.0 to be the default behavior. Fixes #18614.This PR is starting out in draft form to locate affected tests (of which there many). I'll request a review once all the tests broken by this PR are running again.
Release Note Template for Downstream PRs (will be copied)