Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the source-regions examples to the HealthCheck yaml file. #11459

Merged
merged 16 commits into from
Aug 26, 2024

Conversation

pournami-rajan
Copy link
Member

Add the source-regions examples to the HealthCheck yaml file which was missed during the google-beta changes in #10878.


@pournami-rajan pournami-rajan marked this pull request as ready for review August 15, 2024 19:13
@github-actions github-actions bot requested a review from NickElliot August 15, 2024 19:14
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 183 insertions(+))
google-beta provider: Diff ( 2 files changed, 183 insertions(+))
Open in Cloud Shell: Diff ( 12 files changed, 336 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 984
Passed tests: 908
Skipped tests: 72
Affected tests: 4

Click here to see the affected service packages
  • compute

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeHealthCheck_computeHealthCheckHttpSourceRegionsExample
  • TestAccComputeHealthCheck_computeHealthCheckHttpsSourceRegionsExample
  • TestAccComputeHealthCheck_computeHealthCheckTcpSourceRegionsExample
  • TestAccComputeInstance_bootDisk_storagePoolSpecified

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeHealthCheck_computeHealthCheckHttpSourceRegionsExample[Debug log]
TestAccComputeHealthCheck_computeHealthCheckHttpsSourceRegionsExample[Debug log]
TestAccComputeHealthCheck_computeHealthCheckTcpSourceRegionsExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstance_bootDisk_storagePoolSpecified[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

Copy link

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add min_version: beta to the examples?

@pournami-rajan
Copy link
Member Author

can you add min_version: beta to the examples?

Trying to understand, is this for better coverage? The GA changes were already in and was tested successfully.

@github-actions github-actions bot requested a review from NickElliot August 21, 2024 20:48
Copy link

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misunderstood with the linked PR being beta only -- LGTM

@NickElliot NickElliot merged commit d821caa into GoogleCloudPlatform:main Aug 26, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants