Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data source "google_privileged_access_manger_entitlement" #11588

Merged
merged 88 commits into from
Sep 23, 2024
Merged

Add data source "google_privileged_access_manger_entitlement" #11588

merged 88 commits into from
Sep 23, 2024

Conversation

varsharmavs
Copy link
Contributor

@varsharmavs varsharmavs commented Aug 30, 2024 •
edited
Loading 

`google_privileged_access_manager_entitlement`

varsharmavs and others added 30 commits April 1, 2024 04:43
@varsharmavs
terraform Support for Managing Entitlement.
da05f83
@varsharmavs
Added privilegedacessmanager to './mmv1/third_party/terraform/.teamci…
d558874 
…ty/components/inputs/services_beta.kt'
@varsharmavs
Fixed Indentation and Removed Trailing Spaces
dbea33a
@varsharmavs
Fixed Indentation
afff779
@varsharmavs
Added delete url to support Cascading delete.
f9251d7
@varsharmavs
Marked Manual Approvals as required inside Approval Workflow
9bf29eb
@varsharmavs
Added a create test for privileged_access_manager_enttlement
9834fe3
@varsharmavs
Added pre-delete to support updating the approver list, keeping the a…
97ef2a3 
…pproval workflow set as ForceNew
@varsharmavs
Fixed format in Entitlement.yaml
d9e5f92
@varsharmavs
Updated approvalWorkflow to now support forceNew
cc5309d
@varsharmavs
Merge branch 'GoogleCloudPlatform:main' into main
baba2cf
@varsharmavs
Fixed url Update.
9eff94e
@varsharmavs
Modified basic test file to include all fields.
162c35d
@varsharmavs
Added Update tests
cbf2a3b
@varsharmavs
Merge branch 'GoogleCloudPlatform:main' into main
3ebb340
@varsharmavs
Added conditionExpression field and descriptions to two fields
2799669
@varsharmavs
Merge remote-tracking branch 'upstream/main'
99b4226
@varsharmavs
Updated services_ga.kt to include privilegedaccessmanager and Entitle…
29f121f 
…ment.yaml file to have min size 1 in principals field.
@varsharmavs @NickElliot
Update mmv1/products/privilegedaccessmanager/product.yaml
26b513e 
Co-authored-by: Nick Elliot <nickelliot@google.com>
@varsharmavs
Removed trailing spaces from Entitlement.yaml
3c0e974
@varsharmavs
Updated test file
e534e7f
@varsharmavs
Renamed the test file
9c85c80
@varsharmavs
Added 'min_version:beta' to Entitlement
264cbd0
@varsharmavs
Merge branch 'GoogleCloudPlatform:main' into main
9f82986
@varsharmavs
Removed Required from description to avoid repeatations in doc
7a1ab4e
@varsharmavs
Changed parent and location to include Environment Variables
f7cc768
@varsharmavs
Replaced location with static values
1ec89f2
@varsharmavs
Replaced project name with the static value: 'ci-test-project-188019'
0bfb66e
@varsharmavs
added min_size and max_size to approvers and principals
fb5ccd8
@varsharmavs @NickElliot
Update mmv1/third_party/terraform/services/privilegedaccessmanager/re…
40785ff 
…source_privileged_access_manager_entitlement_test.go.erb

Co-authored-by: Nick Elliot <nickelliot@google.com>
@melinath melinath requested a review from NickElliot September 19, 2024 15:28
@melinath
Copy link
Member

reassigning due to OOO

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Sep 20, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 172 insertions(+))
google-beta provider: Diff ( 3 files changed, 172 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4
Passed tests: 2
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • privilegedaccessmanager

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceGooglePrivilegedAccessManagerEntitlement_basic
  • TestAccDataSourceGooglePrivilegedAccessManagerEntitlement_optionalProject

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataSourceGooglePrivilegedAccessManagerEntitlement_basic[Error message] [Debug log]
TestAccDataSourceGooglePrivilegedAccessManagerEntitlement_optionalProject[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@github-actions github-actions bot requested a review from melinath September 23, 2024 03:33
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Sep 23, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 175 insertions(+))
google-beta provider: Diff ( 3 files changed, 175 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4
Passed tests: 2
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • privilegedaccessmanager

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceGooglePrivilegedAccessManagerEntitlement_basic
  • TestAccDataSourceGooglePrivilegedAccessManagerEntitlement_optionalProject

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGooglePrivilegedAccessManagerEntitlement_basic[Debug log]
TestAccDataSourceGooglePrivilegedAccessManagerEntitlement_optionalProject[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

NickElliot
NickElliot approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligns with the PAM Entitlement resource implemented previously and tests are good, LGTM! One comment for formatting that I'll commit in myself so this can be merged before go conversion.

mmv1/third_party/terraform/provider/provider_mmv1_resources.go.erb Outdated Show resolved Hide resolved
@github-actions github-actions bot requested a review from NickElliot September 23, 2024 20:36
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Sep 23, 2024
@NickElliot NickElliot merged commit 151c1af into GoogleCloudPlatform:main Sep 23, 2024
4 of 5 checks passed
This was referenced Sep 23, 2024
Merged
Merged
abd-goog pushed a commit to abd-goog/magic-modules that referenced this pull request Sep 26, 2024
@varsharmavs @NickElliot @abd-goog
Add data source "google_privileged_access_manger_entitlement" (Google…
172de50 
…CloudPlatform#11588)

Co-authored-by: Nick Elliot <nickelliot@google.com>
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024
@varsharmavs @NickElliot @niharika-98
Add data source "google_privileged_access_manger_entitlement" (Google…
4a65116 
…CloudPlatform#11588)

Co-authored-by: Nick Elliot <nickelliot@google.com>
ankurdua added a commit to ankurdua/magic-modules that referenced this pull request Oct 11, 2024
@ankurdua
Add documentation for google_privileged_access_manager_entitlement da…
06d3a0c 
…ta source.

The data source itself was added in GoogleCloudPlatform#11588.

Followed https://github.com/GoogleCloudPlatform/magic-modules/blob/main/docs/content/develop/handwritten-docs-style-guide.md for writing this documentation.
ankurdua added a commit to ankurdua/magic-modules that referenced this pull request Oct 11, 2024
@ankurdua
Add documentation for google_privileged_access_manager_entitlement da…
62b98be 
…ta source.

The data source itself was added in GoogleCloudPlatform#11588.

Followed https://github.com/GoogleCloudPlatform/magic-modules/blob/main/docs/content/develop/handwritten-docs-style-guide.md for writing this documentation.
@ankurdua ankurdua mentioned this pull request Oct 11, 2024
Merged
This was referenced Oct 16, 2024
Merged
Merged
Merged
Philip-Jonany pushed a commit to Philip-Jonany/magic-modules that referenced this pull request Nov 4, 2024
@varsharmavs @NickElliot
Add data source "google_privileged_access_manger_entitlement" (Google…
a0cc93e 
…CloudPlatform#11588)

Co-authored-by: Nick Elliot <nickelliot@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melinath melinath Awaiting requested review from melinath

@NickElliot NickElliot Awaiting requested review from NickElliot

Assignees
No one assigned
Labels
awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/privilegedaccessmanager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@varsharmavs @modular-magician @melinath @NickElliot