Refactor muxing 1 : Re-use same config to configure the SDK and PF providers, fix VCR testing#11903

Merged

SarahFrench merged 21 commits intoGoogleCloudPlatform:mainfrom SarahFrench:mux-refactor-4-reuse-sdk-config

Nov 21, 2024

+301-273

Commits on Oct 25, 2024

Add comments highlighting that parallel schemas are needed and must match
SarahFrench
committed
When creating the PF provider, store a pointer to the SDK provider struct
SarahFrench
committed
Update the plugin-framework provider to pass the SDK's Config meta struct to all data sources and resources, instead of FrameworkProviderConfig
SarahFrench
committed
Update all PF-implemented things to use the Config struct, update the Config struct to be usable in those places.
SarahFrench
committed
Update google_provider_config_plugin_framework to use Config struct, adapt to type system changes
SarahFrench
committed
Update TestFrameworkProvider_impl to use primary when creating PF provider
SarahFrench
committed
Fix how the plugin-framework is used in VCR tests
SarahFrench
committed
Remove most instances of VCR skips referencing hashicorp/terraform-provider-google#14158
SarahFrench
committed
Update project acctest to reflect how unset string values are now "" in the PF provider's meta struct
SarahFrench
committed
Update request_reason acctest to reflect how unset string values are now ignored and ENVs can be used instead
SarahFrench
committed
Update add_terraform_attribution_label + terraform_attribution_label_addition_strategy acctest to reflect how the SDK configuration logic now affects the PF provider
SarahFrench
committed
Fix TestAccFrameworkProviderBasePath_setBasePath in VCR by removing use of ExternalProviders to get other versions of TPG/TPGB
SarahFrench
committed
Change how acctests check that fields are unset, post-muxing fixes
SarahFrench
committed
Update test for PF handling of request_timeout to use the SDK default value
SarahFrench
committed
Update test for PF handling of request_timeout to expect normalistion of duration strings
SarahFrench
committed
Add tests for existing NonNegativeDurationValidator validator
SarahFrench
committed
Add validators to request_timeout field in the plugin-framework schema, to replace validation that took place in PF configuration logic
SarahFrench
committed

Commits on Oct 28, 2024

Fix check in TestAccFwProvider_user_project_override subtest
SarahFrench
committed

Commits on Nov 7, 2024

Commits on Nov 11, 2024

Add comment about need to stop empty strings being passed from Config to PF-implemented stuff
SarahFrench
authored

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor muxing 1 : Re-use same config to configure the SDK and PF providers, fix VCR testing#11903

Commits on Oct 25, 2024

Add comments highlighting that parallel schemas are needed and must match

When creating the PF provider, store a pointer to the SDK provider struct

Update the plugin-framework provider to pass the SDK's `Config` meta struct to all data sources and resources, instead of `FrameworkProviderConfig`

Update all PF-implemented things to use the Config struct, update the Config struct to be usable in those places.

Update `google_provider_config_plugin_framework` to use Config struct, adapt to type system changes

Update `TestFrameworkProvider_impl` to use primary when creating PF provider

Fix how the plugin-framework is used in VCR tests

Remove most instances of VCR skips referencing hashicorp/terraform-provider-google#14158

Update `project` acctest to reflect how unset string values are now "" in the PF provider's meta struct

Update `request_reason` acctest to reflect how unset string values are now ignored and ENVs can be used instead

Update `add_terraform_attribution_label` + `terraform_attribution_label_addition_strategy` acctest to reflect how the SDK configuration logic now affects the PF provider

Fix TestAccFrameworkProviderBasePath_setBasePath in VCR by removing use of ExternalProviders to get other versions of TPG/TPGB

Change how acctests check that fields are unset, post-muxing fixes

Update test for PF handling of request_timeout to use the SDK default value

Update test for PF handling of request_timeout to expect normalistion of duration strings

Add tests for existing `NonNegativeDurationValidator` validator

Add validators to `request_timeout` field in the plugin-framework schema, to replace validation that took place in PF configuration logic

Commits on Oct 28, 2024

Fix check in `TestAccFwProvider_user_project_override` subtest

Commits on Nov 7, 2024

Update comments to describe conversions between type systems in `google_provider_config_plugin_framework`

go fmt

Commits on Nov 11, 2024

Add comment about need to stop empty strings being passed from Config to PF-implemented stuff