Add support for Regional Managed Instance Groups Resize Request (Dynamic Workload Scheduler) #11968
Conversation
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
modular-magician
added
the
awaiting-approval
| [Output only] Information about the last attempt to fulfill the request. The value is temporary since the ResizeRequest can retry, as long as it's still active and the last attempt value can either be cleared or replaced with a different error. Since ResizeRequest retries infrequently, the value may be stale and no longer show an active problem. The value is cleared when ResizeRequest transitions to the final state (becomes inactive). If the final state is FAILED the error describing it will be storred in the "error" field only. | ||
| output: true | ||
| properties: | ||
| - name: 'error' |
There was a problem hiding this comment.
is this part of the "errors" structure?
Both seem to have similar fields, e.g. locale and locialised message...
There was a problem hiding this comment.
Yes, both refers to errors from mixer_operations.proto
There was a problem hiding this comment.
Is it possible to have a structure we would use in both the places not to copy-paste the same fields so many times?
@rileykarson , maybe you know...
There was a problem hiding this comment.
We do not allow shared types in our codebase- we used to have them, and they introduce a ton of problems when there is variance between the occurrences. There is very often drift between initially-shared types over O(mopnths-years) and we had recurring issues so we removed the ability to specify them to resolve the issues structurally.
I'll preemptively ack that that's very unlikely to be a problem in this specific case and there are some cases where it would be valid and continue to be valid- we saw numerous cases where we were assured they would always be the same, something changed, and suddenly there was drift / variance than invalidated sharing the type in the first place.
chayankumar999
force-pushed
the
chayanr-resize-request
branch
2 times, most recently
from
7450fe4
to
55edf0d
Compare
chayankumar999
force-pushed
the
chayanr-resize-request
branch
from
f2d613e
to
44e414a
Compare
|
Hey @rileykarson, the PR is ready for review now. |
Added support for ResizeRequest feature for Regional Managed Instance Group in Beta.
Alternatively, added support for Regional ResizeRequest feature for R(IGM).
Release Note Template for Downstream PRs (will be copied)