Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with google_compute_(region_)per_instance_config.stateful.ips.ipAddress.address always having diff due to relative vs full path #12056

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
+75 −8
Draft

Fix issue with google_compute_(region_)per_instance_config.stateful.ips.ipAddress.address always having diff due to relative vs full path #12056

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bea7309
Fix issue with google_compute_(region_)per_instance_config.stateful.i…
askubis Oct 18, 2024
7ea3391
fix tests to adhere to recommended way of specifying ip in per_instan…
askubis Oct 21, 2024
db1f49d
add unit tests for the diff supress function
askubis Dec 2, 2024
42110ae
uncomment test changes
askubis Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion mmv1/products/compute/PerInstanceConfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
name: 'PerInstanceConfig'
description: |
A config defined for a single managed instance that belongs to an instance group manager. It preserves the instance name
across instance group manager operations and can define stateful disks or metadata that are unique to the instance.
across instance group manager operations and can define stateful disks, ips or metadata that are unique to the instance.
references:
guides:
'Official Documentation': 'https://cloud.google.com/compute/docs/instance-groups/stateful-migs#per-instance_configs'
Expand Down Expand Up @@ -213,6 +213,7 @@ properties:
type: ResourceRef
description: |
The URL of the reservation for this IP address.
custom_flatten: 'templates/terraform/custom_flatten/full_to_relative_path.tmpl'
custom_expand: 'templates/terraform/custom_expand/resourceref_with_validation.go.tmpl'
resource: 'Address'
imports: 'selfLink'
Expand Down Expand Up @@ -243,6 +244,7 @@ properties:
type: ResourceRef
description: |
The URL of the reservation for this IP address.
custom_flatten: 'templates/terraform/custom_flatten/full_to_relative_path.tmpl'
custom_expand: 'templates/terraform/custom_expand/resourceref_with_validation.go.tmpl'
resource: 'Address'
imports: 'selfLink'
4 changes: 3 additions & 1 deletion mmv1/products/compute/RegionPerInstanceConfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
name: 'RegionPerInstanceConfig'
description: |
A config defined for a single managed instance that belongs to an instance group manager. It preserves the instance name
across instance group manager operations and can define stateful disks or metadata that are unique to the instance.
across instance group manager operations and can define stateful disks, ips or metadata that are unique to the instance.
This resource works with regional instance group managers.
references:
guides:
Expand Down Expand Up @@ -214,6 +214,7 @@ properties:
type: ResourceRef
description: |
The URL of the reservation for this IP address.
custom_flatten: 'templates/terraform/custom_flatten/full_to_relative_path.tmpl'
custom_expand: 'templates/terraform/custom_expand/resourceref_with_validation.go.tmpl'
resource: 'Address'
imports: 'selfLink'
Expand Down Expand Up @@ -244,6 +245,7 @@ properties:
type: ResourceRef
description: |
The URL of the reservation for this IP address.
custom_flatten: 'templates/terraform/custom_flatten/full_to_relative_path.tmpl'
custom_expand: 'templates/terraform/custom_expand/resourceref_with_validation.go.tmpl'
resource: 'Address'
imports: 'selfLink'
Loading