Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Terraform] Fix compute metadata error #1207

Merged
merged 2 commits into from
Jan 10, 2019
Merged

[Terraform] Fix compute metadata error #1207

merged 2 commits into from
Jan 10, 2019

Conversation

emilymye
Copy link
Contributor

@emilymye emilymye commented Jan 9, 2019 •
edited
Loading

Fixes hashicorp/terraform-provider-google#2699
Copy of hashicorp/terraform-provider-google#2832

[all]

[terraform]

Fix compute project metadata error from previous "common_metadata" IDs

[terraform-beta]

Fix compute project metadata error from previous "common_metadata" IDs

[ansible]

[inspec]

@emilymye emilymye requested a review from nat-henderson January 9, 2019 18:50
@emilymye emilymye force-pushed the tf_compute_project_metadata branch from b4f629a to 510ff88 Compare January 9, 2019 18:51
@emilymye
Copy link
Contributor Author

emilymye commented Jan 9, 2019

cc @DeviaVir

@emilymye emilymye mentioned this pull request Jan 9, 2019
Closed
@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#332
depends: hashicorp/terraform-provider-google#2844

@emilymye emilymye force-pushed the tf_compute_project_metadata branch from 510ff88 to 807fba3 Compare January 9, 2019 20:57
@emilymye emilymye requested a review from chrisst January 9, 2019 20:57
@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 52d4682) have been included in your existing downstream PRs.

@emilymye emilymye changed the title Fix compute metadata error [Terraform] Fix compute metadata error Jan 9, 2019
@emilymye emilymye force-pushed the tf_compute_project_metadata branch 3 times, most recently from 8430aef to 02a9146 Compare January 10, 2019 00:16
@emilymye emilymye force-pushed the tf_compute_project_metadata branch from 02a9146 to 07a7d58 Compare January 10, 2019 00:20
@modular-magician
Update tracked submodules -> HEAD on Thu Jan 10 00:23:51 UTC 2019
464d366 
Tracked submodules are build/terraform-beta build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit b5f9478 into GoogleCloudPlatform:master Jan 10, 2019
@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 91f6915) have been included in your existing downstream PRs.

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 1e39982) have been included in your existing downstream PRs.

@Chupaka Chupaka mentioned this pull request Mar 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisst chrisst chrisst approved these changes

@nat-henderson nat-henderson Awaiting requested review from nat-henderson

Assignees
No one assigned
Labels
automerged cla: yes downstream-generated terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emilymye @modular-magician @chrisst @googlebot