Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transcoder: ignored start_time in JobManifestsExample test #12220

Merged

Conversation

wyardley
Copy link
Contributor

@wyardley wyardley commented Nov 1, 2024

Ignored start_time for TestAccTranscoderJob_transcoderJobManifestsExample (assume the other tests aren't failing as often, but could ignore this in some / all of the other ones where end_time is already ignored if desired.

Fixes hashicorp/terraform-provider-google#20004

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@github-actions github-actions bot requested a review from NickElliot November 1, 2024 05:49
Copy link

github-actions bot commented Nov 1, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Nov 1, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 9
Passed tests: 9
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • transcoder

🟢 All tests passed!

View the build log

Copy link

github-actions bot commented Nov 5, 2024

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

github-actions bot commented Nov 7, 2024

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you could do that minor reorder, otherwise LGTM!

Ignored `start_time` for
`TestAccTranscoderJob_transcoderJobManifestsExample`

Fixes hashicorp/terraform-provider-google#20004
@wyardley wyardley force-pushed the wyardley/issues_20004_transcoder branch from 82e904b to def3af3 Compare November 7, 2024 18:24
@github-actions github-actions bot requested a review from NickElliot November 7, 2024 18:24
@wyardley
Copy link
Contributor Author

wyardley commented Nov 7, 2024

@NickElliot done. q: I think this is the one that's caused issues with tests, apparently, but should the field be added to any other attributes as well, or just see if this fixes it?

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Nov 7, 2024
Copy link

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Nov 12, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 9
Passed tests: 9
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • transcoder

🟢 All tests passed!

View the build log

@wyardley
Copy link
Contributor Author

@NickElliot look good now?

Copy link

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NickElliot NickElliot merged commit e6c248f into GoogleCloudPlatform:main Nov 14, 2024
14 checks passed
bradhoekstra pushed a commit to bradhoekstra/magic-modules that referenced this pull request Nov 15, 2024
zeleena pushed a commit to zeleena/magic-modules that referenced this pull request Nov 18, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccTranscoderJob_transcoderJobManifestsExample
3 participants