-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transcoder: ignored start_time
in JobManifestsExample
test
#12220
transcoder: ignored start_time
in JobManifestsExample
test
#12220
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 9 Click here to see the affected service packages
🟢 All tests passed! View the build log |
@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you could do that minor reorder, otherwise LGTM!
Ignored `start_time` for `TestAccTranscoderJob_transcoderJobManifestsExample` Fixes hashicorp/terraform-provider-google#20004
82e904b
to
def3af3
Compare
@NickElliot done. q: I think this is the one that's caused issues with tests, apparently, but should the field be added to any other attributes as well, or just see if this fixes it? |
@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 9 Click here to see the affected service packages
🟢 All tests passed! View the build log |
@NickElliot look good now? |
@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ignored
start_time
forTestAccTranscoderJob_transcoderJobManifestsExample
(assume the other tests aren't failing as often, but could ignore this in some / all of the other ones whereend_time
is already ignored if desired.Fixes hashicorp/terraform-provider-google#20004
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.