Composer 3 GA

[spapi17]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

composer: `google_composer_user_workloads_config_map` promoted to GA

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[spapi17]

Hi @NickElliot,
Please do not merge this PR yet. We'd like to have it reviewed but align the release of this with composer 3 GA rollout.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 19 files changed, 3345 insertions(+), 867 deletions(-))
google-beta provider: Diff ( 8 files changed, 38 insertions(+), 29 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 119 insertions(+))

[modular-magician]

Tests analytics

Total tests: 52
Passed tests: 49
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

• composer

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccComposerEnvironmentComposer2_usesUnsupportedField_expectError
• TestAccComposerEnvironmentComposer3_basic
• TestAccComposerEnvironmentComposer3_update
• TestAccComposerEnvironmentComposer3_updateFromEmpty
• TestAccComposerEnvironmentComposer3_updateToEmpty
• TestAccComposerEnvironmentComposer3_updateWithNetworkAndSubnetwork
• TestAccComposerEnvironmentComposer3_updateWithNetworkAttachment
• TestAccComposerEnvironmentComposer3_upgrade_expectError
• TestAccComposerEnvironmentComposer3_usesUnsupportedField_expectError
• TestAccComposerEnvironmentComposer3_withNetworkAttachment
• TestAccComposerEnvironmentComposer3_withNetworkSubnetworkAndAttachment_expectError
• TestAccComposerUserWorkloadsConfigMap_composerUserWorkloadsConfigMapBasicExample
• TestAccComposerUserWorkloadsConfigMap_composerUserWorkloadsConfigMapBasicExample_delete
• TestAccComposerUserWorkloadsConfigMap_composerUserWorkloadsConfigMapBasicExample_update
• TestAccComposerUserWorkloadsSecret_basic
• TestAccComposerUserWorkloadsSecret_delete
• TestAccComposerUserWorkloadsSecret_update
• TestAccDataSourceComposerUserWorkloadsConfigMap_basic
• TestAccDataSourceComposerUserWorkloadsSecret_basic
  🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 19 files changed, 3340 insertions(+), 867 deletions(-))
google-beta provider: Diff ( 9 files changed, 38 insertions(+), 34 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 119 insertions(+))

[modular-magician]

Tests analytics

Total tests: 52
Passed tests: 47
Skipped tests: 3
Affected tests: 2

Click here to see the affected service packages

• composer

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccComposerEnvironmentComposer2_usesUnsupportedField_expectError
• TestAccComposerEnvironmentComposer3_basic
• TestAccComposerEnvironmentComposer3_update
• TestAccComposerEnvironmentComposer3_updateFromEmpty
• TestAccComposerEnvironmentComposer3_updateToEmpty
• TestAccComposerEnvironmentComposer3_updateWithNetworkAndSubnetwork
• TestAccComposerEnvironmentComposer3_updateWithNetworkAttachment
• TestAccComposerEnvironmentComposer3_upgrade_expectError
• TestAccComposerEnvironmentComposer3_usesUnsupportedField_expectError
• TestAccComposerEnvironmentComposer3_withNetworkAttachment
• TestAccComposerEnvironmentComposer3_withNetworkSubnetworkAndAttachment_expectError
• TestAccComposerUserWorkloadsConfigMap_composerUserWorkloadsConfigMapBasicExample
• TestAccComposerUserWorkloadsConfigMap_composerUserWorkloadsConfigMapBasicExample_delete
• TestAccComposerUserWorkloadsConfigMap_composerUserWorkloadsConfigMapBasicExample_update
• TestAccComposerUserWorkloadsSecret_basic
• TestAccComposerUserWorkloadsSecret_delete
• TestAccComposerUserWorkloadsSecret_update
• TestAccDataSourceComposerUserWorkloadsConfigMap_basic
• TestAccDataSourceComposerUserWorkloadsSecret_basic

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComposerUserWorkloadsConfigMap_composerUserWorkloadsConfigMapBasicExample_delete
• TestAccComposerUserWorkloadsConfigMap_composerUserWorkloadsConfigMapBasicExample_update

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComposerUserWorkloadsConfigMap_composerUserWorkloadsConfigMapBasicExample_delete [Error message] [Debug log]
TestAccComposerUserWorkloadsConfigMap_composerUserWorkloadsConfigMapBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 19 files changed, 3340 insertions(+), 867 deletions(-))
google-beta provider: Diff ( 9 files changed, 40 insertions(+), 36 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 119 insertions(+))

[modular-magician]

Tests analytics

Total tests: 52
Passed tests: 49
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

• composer

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccComposerEnvironmentComposer2_usesUnsupportedField_expectError
• TestAccComposerEnvironmentComposer3_basic
• TestAccComposerEnvironmentComposer3_update
• TestAccComposerEnvironmentComposer3_updateFromEmpty
• TestAccComposerEnvironmentComposer3_updateToEmpty
• TestAccComposerEnvironmentComposer3_updateWithNetworkAndSubnetwork
• TestAccComposerEnvironmentComposer3_updateWithNetworkAttachment
• TestAccComposerEnvironmentComposer3_upgrade_expectError
• TestAccComposerEnvironmentComposer3_usesUnsupportedField_expectError
• TestAccComposerEnvironmentComposer3_withNetworkAttachment
• TestAccComposerEnvironmentComposer3_withNetworkSubnetworkAndAttachment_expectError
• TestAccComposerUserWorkloadsConfigMap_composerUserWorkloadsConfigMapBasicExample
• TestAccComposerUserWorkloadsConfigMap_composerUserWorkloadsConfigMapBasicExample_delete
• TestAccComposerUserWorkloadsConfigMap_composerUserWorkloadsConfigMapBasicExample_update
• TestAccComposerUserWorkloadsSecret_basic
• TestAccComposerUserWorkloadsSecret_delete
• TestAccComposerUserWorkloadsSecret_update
• TestAccDataSourceComposerUserWorkloadsConfigMap_basic
• TestAccDataSourceComposerUserWorkloadsSecret_basic
  🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 19 files changed, 3340 insertions(+), 867 deletions(-))
google-beta provider: Diff ( 9 files changed, 40 insertions(+), 36 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 119 insertions(+))

[modular-magician]

Tests analytics

Total tests: 52
Passed tests: 49
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

• composer

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccComposerEnvironmentComposer2_usesUnsupportedField_expectError
• TestAccComposerEnvironmentComposer3_basic
• TestAccComposerEnvironmentComposer3_update
• TestAccComposerEnvironmentComposer3_updateFromEmpty
• TestAccComposerEnvironmentComposer3_updateToEmpty
• TestAccComposerEnvironmentComposer3_updateWithNetworkAndSubnetwork
• TestAccComposerEnvironmentComposer3_updateWithNetworkAttachment
• TestAccComposerEnvironmentComposer3_upgrade_expectError
• TestAccComposerEnvironmentComposer3_usesUnsupportedField_expectError
• TestAccComposerEnvironmentComposer3_withNetworkAttachment
• TestAccComposerEnvironmentComposer3_withNetworkSubnetworkAndAttachment_expectError
• TestAccComposerUserWorkloadsConfigMap_composerUserWorkloadsConfigMapBasicExample
• TestAccComposerUserWorkloadsConfigMap_composerUserWorkloadsConfigMapBasicExample_delete
• TestAccComposerUserWorkloadsConfigMap_composerUserWorkloadsConfigMapBasicExample_update
• TestAccComposerUserWorkloadsSecret_basic
• TestAccComposerUserWorkloadsSecret_delete
• TestAccComposerUserWorkloadsSecret_update
• TestAccDataSourceComposerUserWorkloadsConfigMap_basic
• TestAccDataSourceComposerUserWorkloadsSecret_basic
  🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 19 files changed, 3343 insertions(+), 867 deletions(-))
google-beta provider: Diff ( 9 files changed, 43 insertions(+), 36 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 119 insertions(+))

[modular-magician]

Tests analytics

Total tests: 52
Passed tests: 49
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

• composer

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccComposerEnvironmentComposer2_usesUnsupportedField_expectError
• TestAccComposerEnvironmentComposer3_basic
• TestAccComposerEnvironmentComposer3_update
• TestAccComposerEnvironmentComposer3_updateFromEmpty
• TestAccComposerEnvironmentComposer3_updateToEmpty
• TestAccComposerEnvironmentComposer3_updateWithNetworkAndSubnetwork
• TestAccComposerEnvironmentComposer3_updateWithNetworkAttachment
• TestAccComposerEnvironmentComposer3_upgrade_expectError
• TestAccComposerEnvironmentComposer3_usesUnsupportedField_expectError
• TestAccComposerEnvironmentComposer3_withNetworkAttachment
• TestAccComposerEnvironmentComposer3_withNetworkSubnetworkAndAttachment_expectError
• TestAccComposerUserWorkloadsConfigMap_composerUserWorkloadsConfigMapBasicExample
• TestAccComposerUserWorkloadsConfigMap_composerUserWorkloadsConfigMapBasicExample_delete
• TestAccComposerUserWorkloadsConfigMap_composerUserWorkloadsConfigMapBasicExample_update
• TestAccComposerUserWorkloadsSecret_basic
• TestAccComposerUserWorkloadsSecret_delete
• TestAccComposerUserWorkloadsSecret_update
• TestAccDataSourceComposerUserWorkloadsConfigMap_basic
• TestAccDataSourceComposerUserWorkloadsSecret_basic
  🟢 All tests passed!

View the build log

[github-actions]

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[NickElliot]

can you remove all the "min_version" tags? They're unneeded entirely with GA, don't need to specifically specify it :)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 19 files changed, 3343 insertions(+), 867 deletions(-))
google-beta provider: Diff ( 9 files changed, 43 insertions(+), 36 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 119 insertions(+))

[modular-magician]

Tests analytics

Total tests: 52
Passed tests: 49
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

• composer

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccComposerEnvironmentComposer2_usesUnsupportedField_expectError
• TestAccComposerEnvironmentComposer3_basic
• TestAccComposerEnvironmentComposer3_update
• TestAccComposerEnvironmentComposer3_updateFromEmpty
• TestAccComposerEnvironmentComposer3_updateToEmpty
• TestAccComposerEnvironmentComposer3_updateWithNetworkAndSubnetwork
• TestAccComposerEnvironmentComposer3_updateWithNetworkAttachment
• TestAccComposerEnvironmentComposer3_upgrade_expectError
• TestAccComposerEnvironmentComposer3_usesUnsupportedField_expectError
• TestAccComposerEnvironmentComposer3_withNetworkAttachment
• TestAccComposerEnvironmentComposer3_withNetworkSubnetworkAndAttachment_expectError
• TestAccComposerUserWorkloadsConfigMap_composerUserWorkloadsConfigMapBasicExample
• TestAccComposerUserWorkloadsConfigMap_composerUserWorkloadsConfigMapBasicExample_delete
• TestAccComposerUserWorkloadsConfigMap_composerUserWorkloadsConfigMapBasicExample_update
• TestAccComposerUserWorkloadsSecret_basic
• TestAccComposerUserWorkloadsSecret_delete
• TestAccComposerUserWorkloadsSecret_update
• TestAccDataSourceComposerUserWorkloadsConfigMap_basic
• TestAccDataSourceComposerUserWorkloadsSecret_basic
  🟢 All tests passed!

View the build log

[NickElliot]

LGTM