Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beyondcorp application #12919

Merged
merged 2 commits into from
Feb 1, 2025
Merged

Conversation

trodge
Copy link
Contributor

@trodge trodge commented Jan 29, 2025

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

Reapplied `google_beyondcorp_application`

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 2127 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 10 files changed, 2127 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 481 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 114 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_beyondcorp_application (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_beyondcorp_application" "primary" {
  endpoint_matchers {
    ports = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 38
Passed tests: 26
Skipped tests: 4
Affected tests: 8

Click here to see the affected service packages
  • beyondcorp
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBeyondcorpApplicationIamBindingGenerated_withAndWithoutCondition
  • TestAccBeyondcorpApplicationIamMemberGenerated_withAndWithoutCondition

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBeyondcorpApplicationIamBindingGenerated
  • TestAccBeyondcorpApplicationIamBindingGenerated_withCondition
  • TestAccBeyondcorpApplicationIamMemberGenerated
  • TestAccBeyondcorpApplicationIamMemberGenerated_withCondition
  • TestAccBeyondcorpApplicationIamPolicyGenerated
  • TestAccBeyondcorpApplicationIamPolicyGenerated_withCondition
  • TestAccBeyondcorpApplication_beyondcorpSecurityGatewayApplicationBasicExample
  • TestAccBeyondcorpApplication_beyondcorpSecurityGatewayApplicationBasicExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBeyondcorpApplicationIamBindingGenerated [Debug log]
TestAccBeyondcorpApplicationIamBindingGenerated_withCondition [Debug log]
TestAccBeyondcorpApplicationIamMemberGenerated [Debug log]
TestAccBeyondcorpApplicationIamMemberGenerated_withCondition [Debug log]
TestAccBeyondcorpApplicationIamPolicyGenerated [Debug log]
TestAccBeyondcorpApplicationIamPolicyGenerated_withCondition [Debug log]
TestAccBeyondcorpApplication_beyondcorpSecurityGatewayApplicationBasicExample [Debug log]
TestAccBeyondcorpApplication_beyondcorpSecurityGatewayApplicationBasicExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@trodge trodge requested a review from c2thorn January 30, 2025 23:27
Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so

  error: {}

was the only invalid async field in https://github.com/GoogleCloudPlatform/magic-modules/pull/12837/files?

@c2thorn
Copy link
Member

c2thorn commented Jan 31, 2025

thanks for carrying this forward @trodge

@trodge trodge added this pull request to the merge queue Feb 1, 2025
Merged via the queue into GoogleCloudPlatform:main with commit c0cff93 Feb 1, 2025
16 checks passed
@trodge trodge deleted the beyondcorp-application branch February 1, 2025 00:41
PerlMonker303 pushed a commit to PerlMonker303/magic-modules that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants