-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beyondcorp application #12919
Beyondcorp application #12919
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_beyondcorp_application" "primary" {
endpoint_matchers {
ports = # value needed
}
}
|
Tests analyticsTotal tests: 38 Click here to see the affected service packages
🔴 Tests were added that are skipped in VCR:
Action takenFound 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so
error: {}
was the only invalid async field in https://github.com/GoogleCloudPlatform/magic-modules/pull/12837/files?
thanks for carrying this forward @trodge |
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.