Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding datasources for folder and project org policy #1435

Merged
merged 2 commits into from
Mar 14, 2019
Merged

Adding datasources for folder and project org policy #1435

merged 2 commits into from
Mar 14, 2019

Conversation

chrisst
Copy link
Contributor

@chrisst chrisst commented Feb 27, 2019 •
edited
Loading

[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

@chrisst chrisst requested a review from rileykarson February 27, 2019 00:13
@chrisst chrisst force-pushed the org-policy-datasources branch 3 times, most recently from 41a0ec8 to 4e1ceaf Compare February 27, 2019 19:14
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 4e1ceaf8d3bf28c70390bb605ad76dbdfc80c8f3.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#468
depends: hashicorp/terraform-provider-google#3137

rileykarson
rileykarson reviewed Feb 28, 2019
View reviewed changes
Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests?

Also, I think the original issue was for import and not datasources 😛

@chrisst
Copy link
Contributor Author

chrisst commented Feb 28, 2019

Wow, I went down a really long tangential path that didn't fix the original issue 🤦🏼‍♂️

@chrisst chrisst force-pushed the org-policy-datasources branch from 06aaa9a to 535215f Compare March 12, 2019 00:14
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 535215f.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@chrisst
Copy link
Contributor Author

chrisst commented Mar 12, 2019

@rileykarson took me a minute, but tests are have been added.

rileykarson
rileykarson approved these changes Mar 12, 2019
View reviewed changes
third_party/terraform/tests/data_source_google_folder_organization_policy_test.go Outdated Show resolved Hide resolved
third_party/terraform/tests/data_source_google_folder_organization_policy_test.go
})
}

func testAccDataSourceGoogleOrganizationPolicyCheck(dataSourceName string, resourceName string) resource.TestCheckFunc {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm partial to namespacing this & duplicating it into each datasource, but don't care enough to block on it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking the right move would be to make a fully generic comparison, or generate them. But for now I think it's sixes.

@chrisst chrisst force-pushed the org-policy-datasources branch from 535215f to c603081 Compare March 13, 2019 21:53
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, c603081.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@chrisst chrisst added this to the 2.3.0 milestone Mar 14, 2019
@modular-magician modular-magician merged commit c28a75d into GoogleCloudPlatform:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileykarson rileykarson rileykarson approved these changes

Assignees
No one assigned
Labels
automerged cla: yes downstream-generated no-op terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisst @modular-magician @rileykarson @googlebot