Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inspec resource folder #1460

Merged
merged 9 commits into from
Mar 1, 2019
Merged

Inspec resource folder #1460

merged 9 commits into from
Mar 1, 2019

Conversation

slevenick
Copy link
Contributor

Add MM description of resource manager folder. Add InSpec support for folder

[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 7fa913a.

Pull request statuses

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#482
depends: hashicorp/terraform-provider-google#3157
depends: modular-magician/ansible#199
depends: modular-magician/inspec-gcp#120

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 9cff635.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 0b4285f.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

@slevenick slevenick requested a review from rambleraptor March 1, 2019 18:58
rambleraptor
rambleraptor approved these changes Mar 1, 2019
View reviewed changes
overrides/inspec/resource_override.rb
@@ -22,6 +22,8 @@ def self.attributes
%i[
manual
additional_functions
product_url
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have a way of overriding the collection_url already?

(Might've imagined that)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not the collection_url, it's the base googleapis/v1/ so that I can use a v2 API for some resources without changing the other resources (they aren't on v2)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

overrides/inspec/resource_override.rb
@@ -22,6 +22,8 @@ def self.attributes
%i[
manual
additional_functions
product_url
privileged
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment for what priviledged means? The rest seem self-explanatory.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 913b035.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician modular-magician force-pushed the inspec-resource-folder branch from 913b035 to bc59c5c Compare March 1, 2019 20:42
@modular-magician modular-magician merged commit 875da19 into master Mar 1, 2019
@slevenick slevenick deleted the inspec-resource-folder branch April 15, 2019 19:41
@modular-magician modular-magician mentioned this pull request Apr 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rambleraptor rambleraptor rambleraptor approved these changes

Assignees
No one assigned
Labels
ansible automerged cla: yes downstream-generated inspec no-op terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slevenick @modular-magician @rambleraptor @googlebot