Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform: Support for (Regional)Disk physicalBlockSizeBytes #1513

Merged

Conversation

drebes
Copy link
Member

@drebes drebes commented Mar 13, 2019


[all]

Adds physicalBlockSizeBytes to Compute Zonal Disks and Regional Disks.

[terraform]

[terraform-beta]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 2634c06.

Pull request statuses

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#526
depends: GoogleCloudPlatform/terraform-google-conversion#18
depends: hashicorp/terraform-provider-google#3237
depends: modular-magician/ansible#211
depends: modular-magician/inspec-gcp#126

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for another great contribution @drebes!

drebes and others added 2 commits March 13, 2019 22:56
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician force-pushed the terraform-disk-blocksize branch from 2634c06 to d603588 Compare March 13, 2019 22:56
@modular-magician modular-magician merged commit 2138817 into GoogleCloudPlatform:master Mar 13, 2019
@drebes drebes deleted the terraform-disk-blocksize branch March 13, 2020 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants