Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cloudbuild trigger disabled field a bool #1630

Merged
merged 3 commits into from
Apr 8, 2019

Conversation

emilymye
Copy link
Contributor

@emilymye emilymye commented Apr 8, 2019

String --> bool

Fixes hashicorp/terraform-provider-google#3299


[all]

[terraform]

Make cloudbuild trigger disabled field a bool

[terraform-beta]

Make cloudbuild trigger disabled field a bool

[ansible]

[inspec]

@emilymye
Copy link
Contributor Author

emilymye commented Apr 8, 2019

make testacc TEST=./google TESTARGS='--run="TestAccCloudBuildTrigger"'
==> Checking source code against gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google -v --run="TestAccCloudBuildTrigger" -timeout 240m -ldflags="-X=github.com/terraform-providers/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccCloudBuildTrigger_cloudbuildTriggerFilenameExample
=== PAUSE TestAccCloudBuildTrigger_cloudbuildTriggerFilenameExample
=== RUN   TestAccCloudBuildTrigger_basic
=== PAUSE TestAccCloudBuildTrigger_basic
=== RUN   TestAccCloudBuildTrigger_disable
=== PAUSE TestAccCloudBuildTrigger_disable
=== RUN   TestAccCloudBuildTrigger_fullStep
=== PAUSE TestAccCloudBuildTrigger_fullStep
=== CONT  TestAccCloudBuildTrigger_cloudbuildTriggerFilenameExample
=== CONT  TestAccCloudBuildTrigger_fullStep
=== CONT  TestAccCloudBuildTrigger_disable
=== CONT  TestAccCloudBuildTrigger_basic
--- PASS: TestAccCloudBuildTrigger_fullStep (1.94s)
--- PASS: TestAccCloudBuildTrigger_cloudbuildTriggerFilenameExample (2.34s)
--- PASS: TestAccCloudBuildTrigger_disable (3.90s)
--- PASS: TestAccCloudBuildTrigger_basic (3.97s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	4.337s

@emilymye emilymye requested review from chrisst and rileykarson and removed request for chrisst April 8, 2019 20:02
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of ce5a9d7699727a008fee756261dc563340e2a545.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#595
depends: hashicorp/terraform-provider-google#3398
depends: modular-magician/ansible#230

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of b8ae7a6.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants