Use new client invocation with client libs #1704
Conversation
| @@ -143,161 +143,161 @@ func (c *Config) LoadAndValidate() error { | |||
| c.userAgent = userAgent | |||
|
|
|||
| log.Printf("[INFO] Instantiating GCE client...") | |||
| c.clientCompute, err = compute.New(client) | |||
| c.clientCompute, err = compute.NewService(context.Background(), option.WithHTTPClient(client)) | |||
There was a problem hiding this comment.
We should instantiate context.Background a single time and pass the shared object to all these clients. This will allow us to create a context tree that can allow cancelling 1 or all requests when the parent is cancelled.
There was a problem hiding this comment.
Not sure it does anything- we never cancel the parent anyways, and most requests end pretty soon- but done.
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in Ansible. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
|
(magician is red because I ran the job by hand after fixing the broken downstream) |
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
modular-magician
force-pushed
the
deprecated-client
branch
from
2c334c4 to
086ea30
Compare
Required for hashicorp/terraform-provider-google#3529, hashicorp/terraform-provider-google-beta#650 to pass Travis, both of those are required for this pass
terraform-testI think[all]
[terraform]
[terraform-beta]
[ansible]
[inspec]