Make cloud composer environment image version updateable. #1755
Conversation
|
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs. Thanks for your contribution! A human will be with you soon. |
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
There was a problem hiding this comment.
Hi @jmcarp! Can you also add this property to TestAccComposerEnvironment_update in resource_composer_environment_test.go?
| }, | ||
| } | ||
| if config != nil && config.SoftwareConfig != nil { | ||
| patchObj.Config.SoftwareConfig = config.SoftwareConfig.ImageVersion |
There was a problem hiding this comment.
| patchObj.Config.SoftwareConfig = config.SoftwareConfig.ImageVersion | |
| patchObj.Config.SoftwareConfig.ImageVersion = config.SoftwareConfig.ImageVersion |
jmcarp
force-pushed
the
composer-update-image-version
branch
from
9373109 to
aff02ff
Compare
|
Thanks @danawillow. I added your fix and updated the tests, and got the updated test passing. |
| name = "%s" | ||
| region = "us-central1" | ||
|
|
||
| config { |
There was a problem hiding this comment.
Does the test still work without this block? My philosophy is that the basic test should be, for the most part, the minimum that you need in order to get a resource provisioned.
There was a problem hiding this comment.
Thanks, looks like I didn't need to add this block. Updated.
jmcarp
force-pushed
the
composer-update-image-version
branch
from
aff02ff to
ef87d27
Compare
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
| @@ -295,6 +295,8 @@ resource "google_composer_environment" "test" { | |||
| node_count = 4 | |||
|
|
|||
| software_config { | |||
| image_version = "composer-1.7.0-airflow-1.10.2" | |||
There was a problem hiding this comment.
Ah sorry I didn't catch this earlier- this also needs beta-only guards, since without it the test in the GA provider will destroy/create instead of doing an update.
jmcarp
force-pushed
the
composer-update-image-version
branch
from
ef87d27 to
cb3e6d0
Compare
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
modular-magician
force-pushed
the
composer-update-image-version
branch
from
cb3e6d0 to
2b68b3c
Compare
Cloud composer now allows image version to be updated as a beta feature. This drops
ForceNewfrom theimage_versionoption and implements version updates for the beta provider. I'm new to magic modules, so still figuring out how to test this.