-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix dnssec test #1842
fix dnssec test #1842
Conversation
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
Your comment made me look further into what that statement meant, and when which fields are returned from the API. Marked another field as computed, added a test, and changed the wording around a little- mind taking a quick second pass? |
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
c40458b
to
0d3b5f0
Compare
Moved dnssec into its own test since it can't be used with private zones and also can't be updated (actually I'm pretty sure that it can, but that should be fixed in a future PR. My impression from looking at the docs is that all fields can be updated, but that needs testing and I don't feel like doing that right now).
[all]
[terraform]
[terraform-beta]
[ansible]
[inspec]