Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dnssec test #1842

Merged
merged 3 commits into from
May 29, 2019
Merged

Conversation

danawillow
Copy link
Contributor

Moved dnssec into its own test since it can't be used with private zones and also can't be updated (actually I'm pretty sure that it can, but that should be fixed in a future PR. My impression from looking at the docs is that all fields can be updated, but that needs testing and I don't feel like doing that right now).


[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of f247ef1.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#777
depends: hashicorp/terraform-provider-google#3735
depends: modular-magician/ansible#267

products/dns/api.yaml Show resolved Hide resolved
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, c40458b.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@danawillow
Copy link
Contributor Author

Your comment made me look further into what that statement meant, and when which fields are returned from the API. Marked another field as computed, added a test, and changed the wording around a little- mind taking a quick second pass?

@danawillow danawillow requested a review from tysen May 29, 2019 16:39
danawillow and others added 3 commits May 29, 2019 22:42
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants