Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds 'purpose' to kms_crypto_key #1917

Merged
merged 3 commits into from
Jun 12, 2019
Merged

adds 'purpose' to kms_crypto_key #1917

merged 3 commits into from
Jun 12, 2019

Conversation

gracenoah
Copy link
Contributor

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

@gracenoah
Copy link
Contributor Author

CLA signed

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@danawillow
Copy link
Contributor

/cc @drebes

FYI this is already being taken care of in this other open PR: #1856

If you'd like to do the work in this one as well (since I don't know how long it'll take for the other to be finished), I'd ask to please:

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of ca52dcc.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#845
depends: hashicorp/terraform-provider-google#3843

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @gracenoah!

gracenoah and others added 3 commits June 12, 2019 21:16
@modular-magician modular-magician merged commit 9798a91 into GoogleCloudPlatform:master Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_kms_crypto_key does not support asymmetric (like ECDSA) keys
4 participants