Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix beta dataproc resources by adding min_cpu_platform in master/worker config instead of preemptible #1919

Merged
merged 3 commits into from
Jun 17, 2019

Conversation

danawillow
Copy link
Contributor

No description provided.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of ec34a2c.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#848
depends: GoogleCloudPlatform/terraform-google-conversion#108
depends: hashicorp/terraform-provider-google#3847

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or actually can you also test the new location(s)?

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 974eab3.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@danawillow danawillow changed the title fix beta dataproc resources by adding min_cpu_platform in all the places it exists in the API fix beta dataproc resources by adding min_cpu_platform in master/worker config instead of preemptible Jun 17, 2019
Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming tests pass, 👍

@danawillow
Copy link
Contributor Author

Tests are good, and thanks for the comment because they totally exposed a bug due to a false assumption I made 🙌

danawillow and others added 3 commits June 17, 2019 20:58
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 1bc77f3 into GoogleCloudPlatform:master Jun 17, 2019
@danawillow danawillow deleted the fixdataproc branch June 17, 2019 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants