Ansible support on the Magician #197
Conversation
rambleraptor
force-pushed
the
ansible-noop-bad
branch
from
48901da to
d775457
Compare
|
I am a robot that works on MagicModules PRs! Once this PR is approved, you can feel free to merge it without taking any further steps. |
rambleraptor
force-pushed
the
ansible-noop-bad
branch
from
d775457 to
659bff0
Compare
|
I am a robot that works on MagicModules PRs! Once this PR is approved, you can feel free to merge it without taking any further steps. |
rambleraptor
force-pushed
the
ansible-noop-bad
branch
from
659bff0 to
53e5268
Compare
|
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
rambleraptor
force-pushed
the
ansible-noop-bad
branch
from
53e5268 to
4b20b94
Compare
rambleraptor
changed the title
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit 7c10f86) have been included in your existing downstream PRs. |
.ci/ci.yml.tmpl
Outdated
| params: | ||
| repository: magic-modules-with-comment/build/ansible | ||
| branch_file: magic-modules-with-comment/original_pr_branch_name | ||
| # Every time a change runs through this pipeline, it will generate a commit with |
There was a problem hiding this comment.
Can skip the comment the second time - easy for them to get out of sync. "See comment on terraform push" will do.
|
|
||
| # This command can crash - if that happens, the script should not fail. | ||
| set +e | ||
| ANSIBLE_COMMIT_MSG="$(python .ci/magic-modules/extract_from_pr_description.py --tag ansible < .git/body)" |
There was a problem hiding this comment.
Remember to add the ansible tag to the .github/PULL_REQUEST_TEMPLATE.md.
There was a problem hiding this comment.
A document for how to add a new provider is desperately needed. Right now is beyond witchcraft how to add a new product or provider. Any chance we can do that?
There was a problem hiding this comment.
I have an issue to write that up, but it's not near the top of my list right now. Do you think it should be?
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit e1a5114) have been included in your existing downstream PRs. |
.ci/ci.yml.tmpl
Outdated
| {% macro names_as_list(repo, names) -%} | ||
| {% for name in names %} | ||
| build/{{repo}}/{{name}} | ||
| {%- endfor %} | ||
| {% endmacro -%} | ||
| {% set puppet_submodules = names_as_list('puppet', puppet_modules).split() %} | ||
| {% set all_submodules = puppet_submodules + ['build/terraform'] if terraform_enabled else [] %} | ||
| {% set all_submodules = puppet_submodules + (['build/terraform'] if terraform_enabled else []) + (['build/ansible'] if ansible_enabled else []) %} |
There was a problem hiding this comment.
Could this fit in less than 500 chars? ;-)
|
|
||
| # This command can crash - if that happens, the script should not fail. | ||
| set +e | ||
| ANSIBLE_COMMIT_MSG="$(python .ci/magic-modules/extract_from_pr_description.py --tag ansible < .git/body)" |
There was a problem hiding this comment.
A document for how to add a new provider is desperately needed. Right now is beyond witchcraft how to add a new product or provider. Any chance we can do that?
rambleraptor
force-pushed
the
ansible-noop-bad
branch
from
cd9bca6 to
48901da
Compare
Change-Id: Iba3c1c6226d1f8def660956c37989cfc4cf1999c
* Removed stray comment * Added ansible to Github PR Template Change-Id: Id29a52ddd486b8b5f15020646d3209a2388f37f0
rambleraptor
force-pushed
the
ansible-noop-bad
branch
from
48901da to
20ecfb7
Compare
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit 3ad0874) have been included in your existing downstream PRs. |
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit e0d98af) have been included in your existing downstream PRs. |
* Made all_submodules < 80 chars
rambleraptor
force-pushed
the
ansible-noop-bad
branch
from
20ecfb7 to
eb02195
Compare
|
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
Ansible support on the Magician.
Change-Id: Ifaf460b447f520508589f9048695ae054b11e221
[all]
Ansible support on the Magician.
[terraform]
[puppet]
[puppet-dns]
[puppet-sql]
[puppet-compute]
[chef]