Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't make ACL comparisons if objects are missing #2010

Merged

Conversation

chrisst
Copy link
Contributor

@chrisst chrisst commented Jul 3, 2019

Fixes hashicorp/terraform-provider-google#3949

Release Note for Downstream PRs (will be copied)

`google_storage_object_acl` Prevent panic when using interpolated object names.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 42754f9.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#917
depends: hashicorp/terraform-provider-google#3970

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth logging the reason if we exit early when either field is missing? That way we can review exactly what's happening in debug logs a little more easily.

@chrisst
Copy link
Contributor Author

chrisst commented Jul 3, 2019

When customize diff is running on plan and the resources that are meant to be interpolated are missing it's always going to exit at these points. Also both of these fields are required so the only reason this will exit early is during pre-creation plans.
Given that this is pretty normal exit condition I don't think the added log really adds anything.

chrisst and others added 2 commits July 3, 2019 20:09
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician force-pushed the storage-object-acl-panic branch from 42754f9 to 4f5b78c Compare July 3, 2019 20:09
@modular-magician modular-magician merged commit 2b157ec into GoogleCloudPlatform:master Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when google_storage_object_acl uses output_name from google_storage_bucket_object
4 participants