Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream Bigtable Instance IAM PR #2015

Merged
merged 2 commits into from
Jul 8, 2019

Conversation

rileykarson
Copy link
Member

@rileykarson rileykarson commented Jul 3, 2019

Upstreams hashicorp/terraform-provider-google#3939

Release Note for Downstream PRs (will be copied)

Added IAM resources for bigtable instances (`google_bigtable_instance_iam_policy`,`google_bigtable_instance_iam_binding`, `google_bigtable_instance_iam_member`)

@rileykarson rileykarson requested a review from danawillow July 3, 2019 21:16
@rileykarson rileykarson removed the request for review from danawillow July 3, 2019 21:16
@rileykarson
Copy link
Member Author

Actually, need to apply dependencies to tpgb*

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 9a3a5fb.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#923
depends: GoogleCloudPlatform/terraform-google-conversion#123
depends: hashicorp/terraform-provider-google#3976


resource "google_service_account" "test-account1" {
account_id = "%s-1"
display_name = "Dataproc IAM Testing Account"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be done in a followup so we don't end up with annoying merge stuff, but can these be changed so they don't say Dataproc?

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 9a3a5fb.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 9a3a5fb.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@rileykarson
Copy link
Member Author

Test step is green in https://sunrisecafe.ci.cloud-graphite.com/teams/magic-modules/pipelines/magician/jobs/terraform-test/builds/2972, because this is being triggered off the same commit the GH status isn't updated.

rileykarson and others added 2 commits July 8, 2019 16:08
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants