Copy compute instance description to terraform state #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
paddycarver
approved these changes
Aug 5, 2019
|
@paddycarver I'm not sure how the automation works here. Is it up to me to update the branch? |
|
No, I'm just absentminded and forgot you don't have downstream merge capabilities. I'll take care of getting this merged 👍 |
The terraform provider currently does not import compute instance description even though it is available. This updates import state to copy the description.
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
modular-magician
force-pushed
the
compute-instance-description
branch
from
3475827 to
8b9f983
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The terraform provider currently does not import compute instance description even though it is available. This updates import state to copy the description.
This is an optimistic change: I've tested the change locally by modifying the generated terraform provider, but I'm hoping the change is simple enough that I won't have to figure out how to generate the provider myself.
Release Note for Downstream PRs (will be copied)