Iap iam rework #2178

slevenick · 2019-08-14T16:36:13Z

Generating several IAP resources. Still needed resources are for App Engine services, and specific versions of App Engine services. These are not supported currently in Terraform, and will need either support or manual testing.

Release Note for Downstream PRs (will be copied)

`google_iap_web_iam_binding/_member/_policy` are now available for managing IAP web IAM permissions
`google_iap_web_backend_service_binding/_member/_policy` are now available for managing IAM permissions on IAP enabled backend services
`google_iap_web_type_compute_iam_binding/_member/_policy` are now available for managing IAM permissions on IAP enabled compute services
`google_iap_web_type_app_engine_iam_binding/_member/_policy` are now available for managing IAM permissions on IAP enabled App Engine applications

modular-magician · 2019-08-14T16:56:13Z

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of af0aee6.

Pull request statuses

No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1044
depends: GoogleCloudPlatform/terraform-google-conversion#161
depends: hashicorp/terraform-provider-google#4253
depends: modular-magician/ansible#349

modular-magician · 2019-08-14T17:09:29Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 21e865d.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-08-14T18:17:20Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 888af5e.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-08-15T00:44:42Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 36dae56.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-08-15T01:37:40Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 514e901.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-08-15T01:43:17Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 7c78b87.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-08-15T01:48:50Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 2ef58e0.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-08-15T17:30:47Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 8be580d.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-08-15T18:00:40Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, acbfe47.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-08-15T19:56:13Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, db8d57f.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-08-15T20:28:53Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 32618fc.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

slevenick · 2019-08-16T15:03:03Z

templates/terraform/examples/base_configs/iam_test_file.go.erb

@@ -174,7 +179,10 @@ func testAcc<%= resource_name -%>IamBinding_updateGenerated(context map[string]i
 <%= example.config_test_body -%>

 resource "<%= terraform_name -%>_iam_binding" "foo" {
-	<%= object.name.underscore -%> = "${<%= terraform_name -%>.<%= example.primary_resource_id -%>.id}"
+	<%= params.last.underscore -%> = "${<%= parent_resource_type_type -%>.<%= example.primary_resource_id -%>.<%= object.iam_policy.parent_resource_attribute -%>}"


This currently uses resource.id as IAM resource should be able to parse their parent's id. I plan to change this to use the same code as the documentation example generation, which sets each field in the URL based on the fields of the parent resource.

For example: pubsub topic would set topic = google_pubsub_topic.my_topic.name and project = google_pubsub_topic.my_topic.project.

danawillow

there's a part of me that hopes we encounter other APIs that use some of the stuff from here so that they get some use outside of IAP, and then there's another part that very much hopes we don't.

templates/terraform/iam_policy.go.erb

templates/terraform/resource_iam.html.markdown.erb

third_party/terraform/utils/import.go

templates/terraform/examples/base_configs/iam_test_file.go.erb

templates/terraform/resource_iam.html.markdown.erb

products/iap/api.yaml

modular-magician · 2019-08-26T23:53:25Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, a45a8f2.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-08-27T17:48:47Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, a90f2de.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-08-27T22:09:41Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 58ff68c.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-08-27T22:12:27Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 8f5aeb6.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-08-28T17:12:01Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 34b017f.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

googlebot added the cla: yes label Aug 14, 2019

slevenick force-pushed the iap-iam-rework branch from aceb7c7 to af0aee6 Compare August 14, 2019 16:42

modular-magician added downstream-generated ansible terraform-google-conversion terraform-provider-google-beta terraform-provider-google labels Aug 14, 2019

slevenick added the changelog: new-resource label Aug 15, 2019

slevenick requested a review from danawillow August 15, 2019 20:33

slevenick commented Aug 16, 2019

View reviewed changes

danawillow suggested changes Aug 16, 2019

View reviewed changes

slevenick force-pushed the iap-iam-rework branch from bb7bef1 to 39a71f8 Compare August 26, 2019 22:59

slevenick force-pushed the iap-iam-rework branch from a45a8f2 to a90f2de Compare August 27, 2019 17:34

slevenick force-pushed the iap-iam-rework branch from eb7634b to 34b017f Compare August 28, 2019 16:59

slevenick and others added 24 commits September 5, 2019 21:46

Set state during read

fad345d

Correct primary resource name for appengine test generation

2f0adf7

Add backendServiceName description to iap web backend

d303cd4

Add IAP iam to website

224027b

Extra erb end

9df937a

Reorder website

96d8bc7

Add comments

04eec3f

PR feedback

844410f

Fix rebase issue in website

1929fbd

Refactoring iam attributes

ec10de2

Typo

454ddb4

Refactor examples to use attributes generated during test

77fb300

Website rename

0e62857

Try not setting extra fields

fc1484d

Project doc updates

7cdcc38

Fix import parsing logic

e961994

Enough arguments

c2e787c

Add back pubsub handwritten test

99195a1

PR feedback, spacing, moving methods to iam.go, naming

51a4eee

Add required import

2112af9

Default to viewer role, not editor

fc427bb

PR comments, moving functions/not depending on project.id

10032ea

Remove unused import

58567cb

Update tracked submodules -> HEAD on Thu Sep 5 21:46:55 UTC 2019

d3f06f2

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

modular-magician force-pushed the iap-iam-rework branch from f78dca5 to d3f06f2 Compare September 5, 2019 21:47

modular-magician merged commit 1b038f7 into GoogleCloudPlatform:master Sep 5, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Iap iam rework #2178

Iap iam rework #2178

slevenick commented Aug 14, 2019 •

edited

Loading

modular-magician commented Aug 14, 2019

modular-magician commented Aug 14, 2019

modular-magician commented Aug 14, 2019

modular-magician commented Aug 15, 2019

modular-magician commented Aug 15, 2019

modular-magician commented Aug 15, 2019

modular-magician commented Aug 15, 2019

modular-magician commented Aug 15, 2019

modular-magician commented Aug 15, 2019

modular-magician commented Aug 15, 2019

modular-magician commented Aug 15, 2019

slevenick Aug 16, 2019

danawillow left a comment

modular-magician commented Aug 26, 2019

modular-magician commented Aug 27, 2019

modular-magician commented Aug 27, 2019

modular-magician commented Aug 27, 2019

modular-magician commented Aug 28, 2019

Iap iam rework #2178

Iap iam rework #2178

Conversation

slevenick commented Aug 14, 2019 • edited Loading

Release Note for Downstream PRs (will be copied)

modular-magician commented Aug 14, 2019

Pull request statuses

New Pull Requests

modular-magician commented Aug 14, 2019

Pull request statuses

New Pull Requests

modular-magician commented Aug 14, 2019

Pull request statuses

New Pull Requests

modular-magician commented Aug 15, 2019

Pull request statuses

New Pull Requests

modular-magician commented Aug 15, 2019

Pull request statuses

New Pull Requests

modular-magician commented Aug 15, 2019

Pull request statuses

New Pull Requests

modular-magician commented Aug 15, 2019

Pull request statuses

New Pull Requests

modular-magician commented Aug 15, 2019

Pull request statuses

New Pull Requests

modular-magician commented Aug 15, 2019

Pull request statuses

New Pull Requests

modular-magician commented Aug 15, 2019

Pull request statuses

New Pull Requests

modular-magician commented Aug 15, 2019

Pull request statuses

New Pull Requests

slevenick Aug 16, 2019

Choose a reason for hiding this comment

danawillow left a comment

Choose a reason for hiding this comment

modular-magician commented Aug 26, 2019

Pull request statuses

New Pull Requests

modular-magician commented Aug 27, 2019

Pull request statuses

New Pull Requests

modular-magician commented Aug 27, 2019

Pull request statuses

New Pull Requests

modular-magician commented Aug 27, 2019

Pull request statuses

New Pull Requests

modular-magician commented Aug 28, 2019

Pull request statuses

New Pull Requests

slevenick commented Aug 14, 2019 •

edited

Loading