add ability to update Bigtable instance cluster node count

[rileykarson]

Upstreams hashicorp/terraform-provider-google#4026

Release Note for Downstream PRs (will be copied)

`num_nodes` can now be updated in `google_bigtable_instance`

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[danawillow]

I know I'm here just to give a stamp of approval since you've already reviewed, but can you explain why cluster had to change from a set to a list?

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 084c294.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1067
depends: hashicorp/terraform-provider-google#4293

[rileykarson]

Originally it was required because cluster was ForceNew, and modifying sub-fields of elements of the TypeSet caused changes to appear as an add/remove, causing a ForceNew diff on cluster.

That's not true anymore- it's possible that we could preserve it as a TypeSet now that the field has been marked Computed and we simulate ForceNew in a CustomizeDiff. We already handle the list as unordered, though, and I'm a lot less sure of how TypeSet interacts with a CustomizeDiff than TypeList does.

I think TypeList is the right abstraction for the field given that elements are mutable resources now, so since we can change the type safely I'd like to change it to one.

[danawillow]

Thanks for the explanation!

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 084c294.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 084c294.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.