Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metric descriptor unit to google_logging_metric #2286

Merged
merged 3 commits into from
Sep 6, 2019
Merged

Add metric descriptor unit to google_logging_metric #2286

merged 3 commits into from
Sep 6, 2019

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Sep 5, 2019 •
edited
Loading

Fixes hashicorp/terraform-provider-google#3881

added metric_descriptor.unit to google_logging_metric resource

Release Note for Downstream PRs (will be copied)

added `metric_descriptor.unit` to `google_logging_metric` resource

@megan07 megan07 changed the title Meagn logging metric unit Add metric descriptor unit to google_logging_metric Sep 5, 2019
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 1c9ef65.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1117
depends: GoogleCloudPlatform/terraform-google-conversion#191
depends: hashicorp/terraform-provider-google#4407

@megan07 megan07 requested a review from tysen September 5, 2019 16:42
tysen
tysen reviewed Sep 5, 2019
View reviewed changes
products/logging/terraform.yaml Outdated
@@ -38,6 +38,8 @@ overrides: !ruby/object:Overrides::ResourceOverrides
properties:
metricDescriptor.labels.valueType: !ruby/object:Overrides::Terraform::PropertyOverride
custom_flatten: 'templates/terraform/custom_flatten/default_if_empty.erb'
metricDescriptor.unit: !ruby/object:Overrides::Terraform::PropertyOverride
default_from_api: true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the API default to? As far as I know we're trying to avoid Optional+Computed when possible - might be better to just set a default.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sure, good to know. I can default it to "1". Thanks!

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, bf244c1.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: modular-magician/ansible#385

@megan07 megan07 requested a review from tysen September 5, 2019 20:26
@megan07 megan07 force-pushed the meagn_logging_metric_unit branch from bf244c1 to 60969b1 Compare September 6, 2019 13:58
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 60969b1.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@megan07 megan07 force-pushed the meagn_logging_metric_unit branch from 60969b1 to 59b4bfa Compare September 6, 2019 17:03
@modular-magician modular-magician merged commit 16fbf96 into GoogleCloudPlatform:master Sep 6, 2019
This was referenced Oct 2, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tysen tysen tysen approved these changes

Assignees
No one assigned
Labels
ansible automerged cla: yes downstream-generated terraform-google-conversion terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

google_logging_metric does not support the unit field
4 participants
@megan07 @modular-magician @tysen @googlebot