Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable http timeout errors to be retried #2293

Merged
merged 3 commits into from
Sep 9, 2019
Merged

Enable http timeout errors to be retried #2293

merged 3 commits into from
Sep 9, 2019

Conversation

rileykarson
Copy link
Member

Upstreams hashicorp/terraform-provider-google#4415

Release Note for Downstream PRs (will be copied)

More classes of generic HTTP errors are retried provider-wide.

@rileykarson rileykarson requested a review from tysen September 6, 2019 16:55
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of a3dd223673db61edd1141a2ec129c5f3aa25850d.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1120
depends: GoogleCloudPlatform/terraform-google-conversion#193
depends: hashicorp/terraform-provider-google#4416

@rileykarson rileykarson requested review from emilymye and removed request for tysen September 6, 2019 17:57
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 698eb26.

Pull request statuses

No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1125
depends: GoogleCloudPlatform/terraform-google-conversion#196

@modular-magician
Update tracked submodules -> HEAD on Mon Sep 9 19:55:49 UTC 2019
9992236 
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 857de99 into GoogleCloudPlatform:master Sep 9, 2019
@danawillow
Copy link
Contributor

Does this fix hashicorp/terraform-provider-google#3957 or is there more to do?

@rileykarson
Copy link
Member Author

Possibly! I'm not sure if it will completely resolve it, but this should significantly reduce the # of errors at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilymye emilymye emilymye approved these changes

Assignees
No one assigned
Labels
automerged cla: yes downstream-generated terraform-google-conversion terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rileykarson @modular-magician @danawillow @emilymye @googlebot @spew