Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create better diff messages for TF 3.0.0 commits. #2370

Merged
merged 2 commits into from
Sep 25, 2019
Merged

Create better diff messages for TF 3.0.0 commits. #2370

merged 2 commits into from
Sep 25, 2019

Conversation

nat-henderson
Copy link
Contributor

Ensure that the diffs on the 3.0.0 branch are properly computed against the previous version of the 3.0.0 branch, rather than against a potentially-out-of-date submodule.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, eee20a3.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@nat-henderson
Copy link
Contributor Author

@rileykarson Take a look at #2371 to see how much better this one is - I'm happy with it in the end. Code's a bit nasty, though! Whew.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, fbe782b.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

nat-henderson and others added 2 commits September 25, 2019 17:41
@nat-henderson @modular-magician
Create better diff messages for TF 3.0.0 commits.
69d6566
@modular-magician
Update tracked submodules -> HEAD on Wed Sep 25 17:41:10 UTC 2019
1680df0 
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 3614a0a into master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileykarson rileykarson rileykarson approved these changes

Assignees
No one assigned
Labels
automerged cla: yes downstream-generated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nat-henderson @modular-magician @rileykarson @googlebot