Removing deprecated fields #2436

megan07 · 2019-10-07T16:35:09Z

Fixes hashicorp/terraform-provider-google#4507

Release Note Template for Downstream PRs (will be copied)

`container`: permanently removed `zone` and `region` fields from data source `google_container_engine_versions`.

`compute`: permanently removed `ip_version` field from `google_compute_forwarding_rule`.

`compute`: permanently removed `ipv4_range` field from `google_compute_network`.

`monitoring`: permanently removed `is_internal` and `internal_checkers` fields from `google_monitoring_uptime_check_config`.

`monitoring`: permanently removed `labels` field from `google_monitoring_alert_policy`.

`compute`: permanently removed `auto_create_routes` field from `google_compute_network_peering`.

`compute`: permanently removed `update_strategy` field from `google_compute_region_instance_group_manager`.

`container`: permanently removed `zone`, `region` and `additional_zones` fields from `google_container_cluster`.

`container`: permanently removed `zone` and `region` fields from `google_container_node_pool`.

`storage`: permanently removed `is_live` flag from `google_storage_bucket`.

modular-magician · 2019-10-07T16:45:42Z

3.0.0 diff report as of f84fc403050e5b37f4ee04f835416116149ad9fe

TPG Diff
TPGB Diff
Mapper Diff

slevenick · 2019-10-07T20:26:37Z

templates/terraform/extra_schema_entry/forwarding_rule.erb

+"ip_version": {
+	Type:         schema.TypeString,
+	Optional:     true,
+	Removed:      "ipVersion is not used for regional forwarding rules. Please remove this field if you are using it.",


Do we need the rest of the information (ValidateFunc, ForceNew) if this field is marked removed? Does removed actually prevent the user from specifying it?

slevenick · 2019-10-07T20:51:20Z

third_party/terraform/resources/resource_storage_bucket.go

-			buf.WriteString(fmt.Sprintf("%t-", isLiveV.(bool)))
-		}
-	} else if withStateOk {
+	if withStateOk {


The goal here is to write nothing to the hash code if the state is "ANY"?

That's how I interpreted the note that I removed (and maybe should have left in?). But I could have misinterpreted it.

I think it makes sense, just want to make sure there isn't a case not handled.

If withStateV.(string) == "" was true before, and is_live was defined we would write it to the hash code. Now is_live can't exist, so we never write anything if withStateV.(string) == ""

Sounds good to me!

…ersion changes doc

modular-magician · 2019-10-08T17:05:02Z

3.0.0 diff report as of `0077eb5`

TPG Diff
TPGB Diff
Mapper Diff

modular-magician · 2019-10-08T17:06:23Z

3.0.0 diff report as of `a39f569`

TPG Diff
TPGB Diff
Mapper Diff

modular-magician · 2019-10-08T17:11:16Z

3.0.0 diff report as of `a39f569`

TPG Diff
TPGB Diff
Mapper Diff

* cloudbuild build trigger's trigger template should be required in 3.0.0. (#2352) * cloudbuild build trigger's trigger template should be required in 3.0.0. * Make backend_service.backends.group required. (#2373) * Remove Removed fields (#2391) * deprecated-->removed event notification config (#2390) * deprecated-->removed event notification config * remove singular config from tests/docs * pluralize * Update third_party/terraform/tests/resource_cloudiot_registry_test.go Co-Authored-By: Riley Karson <rileykarson@google.com> * Delete google_project_services in 3.0.0. (#2403) * Changing IAM audit config to be authoritative (#2438) * Changing IAM audit config to be authoritative * Remove unused code + test * Removing deprecated fields (#2436) * Add validation for scratch disks in Instance Template (#2282) * Add validation for scratch disks * Remove source from scratch disk * Use hardcoded image * Add reverse logic * Change default id format from {{name}} to self_link_uri (#2461) * Change default id format from {{name}} to self_link_uri * Updates to generated id formats (#2460) * Update ID fields for various MM-generated resources * gofmt -s -w extra file * Add userinfo.email to default scopes (#2473) * Set GKE Stackdriver defaults to GKE Stackdriver Monitoring (#2471) * only allow instance templates with 375gb scratch disks (#2495) * Update cloudfunction id for 3.0.0 release (#2501) * handle cloudfunctions deprecating nodejs6 (#2499) * Handwritten id updates for several compute resources (#2502) * Composer environment and compute attached disk id updates * Add compute instance * Add instance_from_group and instance_group * IGM id * Instance template tests passing * Add new id format to other calls of parseImportId in IGM * Small refactor to memoize var * Refactor, remove parseImportId in IGM * handle legacy network deprecation (#2508) * Fix gofmt diff in Cloud Functions (#2542) * More handwritten ids (#2527) * Fix cloudfunction formatting, migrate RIGM id * Update security policy resource id * Update target pool id format * Add new id for container cluster * Node pool id updates * PR feedback, using parseImportId for container resources * Formatting * fix container cluster (#2550) * Datasource id updates (#2544) * Update datasources * formatting * Even more handwritten ids (#2540) * Dataproc cluster, job, google project * Update sql ssl cert, database instance ids * Project id comparison include projects/ * remove kubernetes_dashboard from google_container_cluster (#2551) * Add back encoder that always sends autoCreateSubnetworks (#2558) * Allow defining empty taint, remove old DSF (#2537) * Remove encoder, can be done as send_empty_value on autoCreateSubnetworks (#2559) * deprecate 0.11 syntax in docs (datasources) (#2573) * deprecate 0.11 syntax in docs (resources) (#2574) * deprecate 0.11 syntax in docs (magic modules examples) (#2579) * remove long name behavior for pubsub subscriptions, clean up cu… (#2561) * remove long name behavior for pubsub subscriptions, clean up custom expanders * fix build * fix tests * Fix merge conflict in rigm test * Remove unused regexes from rigm (#2602) * Fix missing paren + bad var in resourcepolicy datasource 3.0.0 (#2600) * Test fixes based on integration tests, id formats + other easy fixes (#2605) * Test fixes based on integration tests, id formats + other easy fixes * Compute network id test update * Fix region disk test id * Update subnetwork to remove enable_flow_logs and depend on log_config instead (#2597) * Test updates to not depend on id format. Also test fixes (#2609) * Test updates to not depend on id format. Also test fixes * Typo * location -> region in node pool test * Cluster test fixes (#2611) * Fix container cluster tests, and signed url key, instance group * Fix invalid accessor * Update hand-written resources with `AtLeastOneOf` and `ExactlyOneOf` attributes (#2608) * Rigm/igm field removals for 3.0.0 (#2595) * Remove deprecated IGM fields for 3.0 * fix imports (#2619) * Remove automatic subnetwork creation in GKE (#2615) * Remove automatic subnetwork creation in GKE * Update docs, add Computed * More integration test fixes (#2617) * Fix bigtable for real, scratch disk size, target pool checks * Proxy test fixes * CloudIOT registry set removed field to nil. Add specific id format for access context manager * (r)igm imports for customdiff (#2623) * (r)igm imports for customdiff * Fix schema issues * Fix IGM custom diff and reuse method between resources (#2624) * Forwardingrule ip address (#2620) add the validation function * Remove unused sort import from rigm (#2625) * add composer test fixes, backend bucket signed url key (#2631) * Stop users from specifying bigquery-json in 3.0.0 (#2626) * Send null logConfig if subnetwork is L7ILB (#2635) * Send null logConfig if subnetwork is L7ILB * Move subnet ilb check to only if logConfig unspecified * deprecate 0.11 syntax in tests (datasources) (#2593) * Make master_authorized_networks_config.cidr_blocks Optional in… (#2642) * Make master_authorized_networks_config.cidr_blocks Optional in GKE * Add note * update magic module-generated resources with at_least_one_of (#2639) * add exactly_one_of to magic modules update comment * Update Data Fusion Instance to conform with 3.0.0 id updates (#2649) * Fix IAM doc id_format to new post 3.0.0 style * Add note on id format changes (#2656) * Add upgrade guide for subnetwork log_config (#2653) * Add upgrade guide for subnetwork log_config * Add examples for subnet logConfig update * Wording on upgrade guide * Add note on audit log config (#2658) * Add misc entries to the upgrade guide (#2657) * Add misc entries to the upgrade guide * Remove extra space * add info on scratch disk size and remove duplicate kms_key_self… (#2659) * Add upgrade guide notes. (#2663) * Add upgrade guide for forwarding rule validation (#2666) * Convert old import formats (using non-/) to use /. (#2638) * Convert old import formats (using non-/) to use /. * Upgrade proofreading (#2668) * Add upgrade note for IoT registry event_notification_configs (#2390) (#2651) Merged PR #2651. * sort upgrade guide; change wording in a few places * Password is not actually required. (#2670) * Add improved for_each non-module variant to project service upg… (#2671) * Update bigtable import & tests to 3.0 (#2673) * update upgrade guide (#2665) * update formatting for upgrade doc (#2674) * Add rigm to upgrade guide (#2667) Update docs to be accurate for 3.0 * proofreading changes (#2676) * Add back lost newlines

googlebot added the cla: yes label Oct 7, 2019

megan07 requested a review from slevenick October 7, 2019 16:56

slevenick reviewed Oct 7, 2019

View reviewed changes

slevenick approved these changes Oct 7, 2019

View reviewed changes

megan07 added 5 commits October 7, 2019 16:30

removing deprecated fields

d3483fb

add container changes from deprecated -> removed

1b14590

fix typo

d8e4e81

add container cluster and container node pool to version changes doc

c4d7afb

add link to google_compute_region_instance_group_manager to list in v…

0077eb5

…ersion changes doc

megan07 force-pushed the megan_deprecated_to_removed branch 2 times, most recently from a800c1d to 0077eb5 Compare October 8, 2019 16:58

remove unnecessary attributes from removed fields

a39f569

megan07 merged commit 91b6ff8 into GoogleCloudPlatform:3.0.0 Oct 8, 2019

megan07 mentioned this pull request Oct 8, 2019

Make all Deprecated fields and resources Removed hashicorp/terraform-provider-google#4507

Closed

rileykarson pushed a commit that referenced this pull request Oct 15, 2019

Removing deprecated fields (#2436)

7e38330

megan07 mentioned this pull request Oct 22, 2019

handle legacy network deprecation #2508

Merged

rileykarson pushed a commit that referenced this pull request Oct 24, 2019

Removing deprecated fields (#2436)

1f84b26

rileykarson pushed a commit that referenced this pull request Nov 6, 2019

Removing deprecated fields (#2436)

90ed5ce

slevenick pushed a commit that referenced this pull request Nov 6, 2019

Removing deprecated fields (#2436)

f1985cb

slevenick pushed a commit that referenced this pull request Nov 7, 2019

Removing deprecated fields (#2436)

2634cbf

rileykarson pushed a commit that referenced this pull request Nov 11, 2019

Removing deprecated fields (#2436)

8402a21

slevenick pushed a commit that referenced this pull request Nov 12, 2019

Removing deprecated fields (#2436)

3aaf408

rileykarson pushed a commit that referenced this pull request Nov 13, 2019

Removing deprecated fields (#2436)

227daf3

rileykarson pushed a commit that referenced this pull request Nov 13, 2019

Removing deprecated fields (#2436)

37548fc

alexsomesan mentioned this pull request Nov 25, 2019

Fix GKE test infra attributes for Google provider v3.x.x hashicorp/terraform-provider-kubernetes#700

Merged

jamesyale mentioned this pull request Oct 1, 2020

google_container_engine_versions or google_compute_network does not plan [3.40.0 → 3.41.0] hashicorp/terraform-provider-google#7379

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removing deprecated fields #2436

Removing deprecated fields #2436

megan07 commented Oct 7, 2019

modular-magician commented Oct 7, 2019

slevenick Oct 7, 2019

slevenick Oct 7, 2019

megan07 Oct 7, 2019

slevenick Oct 7, 2019

modular-magician commented Oct 8, 2019

modular-magician commented Oct 8, 2019

modular-magician commented Oct 8, 2019

Removing deprecated fields #2436

Removing deprecated fields #2436

Conversation

megan07 commented Oct 7, 2019

modular-magician commented Oct 7, 2019

3.0.0 diff report as of f84fc403050e5b37f4ee04f835416116149ad9fe

slevenick Oct 7, 2019

Choose a reason for hiding this comment

slevenick Oct 7, 2019

Choose a reason for hiding this comment

megan07 Oct 7, 2019

Choose a reason for hiding this comment

slevenick Oct 7, 2019

Choose a reason for hiding this comment

modular-magician commented Oct 8, 2019

3.0.0 diff report as of 0077eb5

modular-magician commented Oct 8, 2019

3.0.0 diff report as of a39f569

modular-magician commented Oct 8, 2019

3.0.0 diff report as of a39f569

3.0.0 diff report as of `0077eb5`

3.0.0 diff report as of `a39f569`

3.0.0 diff report as of `a39f569`