Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle legacy network deprecation #2508

Merged
merged 3 commits into from
Oct 24, 2019
Merged

handle legacy network deprecation #2508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7fef66
removing remnants of legacy networks
megan07 Oct 21, 2019
332ce5a
making legacy network computed
megan07 Oct 21, 2019
9a84650
update version 3 upgrade guide
megan07 Oct 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion products/compute/terraform.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,7 +918,6 @@ overrides: !ruby/object:Overrides::ResourceOverrides
custom_code: !ruby/object:Provider::Terraform::CustomCode
post_create: templates/terraform/post_create/compute_network_delete_default_route.erb
extra_schema_entry: templates/terraform/extra_schema_entry/network.erb
encoder: templates/terraform/encoders/network.erb
NetworkEndpoint: !ruby/object:Overrides::Terraform::ResourceOverride
id_format: "{{project}}/{{zone}}/{{network_endpoint_group}}/{{instance}}/{{ip_address}}/{{port}}"
mutex: networkEndpoint/{{project}}/{{zone}}/{{network_endpoint_group}}
Expand Down
5 changes: 0 additions & 5 deletions templates/terraform/encoders/network.erb
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion templates/terraform/extra_schema_entry/network.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@
-%>
"ipv4_range": {
Type: schema.TypeString,
Optional: true,
Computed: true,
Removed: "Legacy Networks are deprecated and you will no longer be able to create them using this field from Feb 1, 2020 onwards.",
},
2 changes: 1 addition & 1 deletion third_party/terraform/website/docs/version_3_upgrade.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ Use `location` instead.

### `ipv4_range` is now removed

Legacy Networks are deprecated and you will no longer be able to create them
Legacy Networks are removed and you will no longer be able to create them
using this field from Feb 1, 2020 onwards.

## Resource: `google_compute_network_peering`
Expand Down