Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dataproc component gateway #2526

Merged

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Oct 23, 2019

Release Note Template for Downstream PRs (will be copied)

[beta-only]dataproc: added component gateway support to `google_dataproc_cluster`

Fixes hashicorp/terraform-provider-google#4128

Note:
The Component Gateway feature is in alpha, so I reached out to the Dataproc team to see if it would be a good idea to support it now. This PR will be available to anyone who wants it, but it won't be merged until we have a stronger sense of if the API will remain as it is now.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 4866290.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1298
depends: hashicorp/terraform-provider-google#4745

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, fe9c23a.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@danawillow
Copy link
Contributor

LGTM. I'm going to hold off on approving this until the feature is in beta so we don't accidentally merge this.

@c2thorn c2thorn closed this Nov 15, 2019
@c2thorn c2thorn deleted the dataproc_component_gateway branch November 15, 2019 18:57
@c2thorn c2thorn restored the dataproc_component_gateway branch November 15, 2019 19:00
@c2thorn c2thorn reopened this Nov 15, 2019
@c2thorn c2thorn force-pushed the dataproc_component_gateway branch from fe9c23a to a14b110 Compare May 5, 2020 00:09
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 21 insertions(+))
Terraform Beta: Diff ( 3 files changed, 143 insertions(+), 37 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 21 insertions(+))
Terraform Beta: Diff ( 3 files changed, 107 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 21 insertions(+))
Terraform Beta: Diff ( 3 files changed, 105 insertions(+))

@c2thorn
Copy link
Member Author

c2thorn commented May 5, 2020

Updated these changes to fit with the current provider (3.0.0 changes, vcr, etc). Also added a computed only field.

@c2thorn c2thorn requested a review from danawillow May 5, 2020 16:35
Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a [beta-only] note to the changelog so the release mgr knows not to put it in the one for the GA provider?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataproc enable "Component gateway"?
4 participants