-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dataproc component gateway #2526
Add dataproc component gateway #2526
Conversation
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
third_party/terraform/resources/resource_dataproc_cluster.go.erb
Outdated
Show resolved
Hide resolved
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
LGTM. I'm going to hold off on approving this until the feature is in beta so we don't accidentally merge this. |
fe9c23a
to
a14b110
Compare
Updated these changes to fit with the current provider (3.0.0 changes, vcr, etc). Also added a computed only field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a [beta-only] note to the changelog so the release mgr knows not to put it in the one for the GA provider?
Release Note Template for Downstream PRs (will be copied)
Fixes hashicorp/terraform-provider-google#4128
Note:The Component Gateway feature is in alpha, so I reached out to the Dataproc team to see if it would be a good idea to support it now. This PR will be available to anyone who wants it, but it won't be merged until we have a stronger sense of if the API will remain as it is now.