-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix google_project
default network deletion by correcting URL
#2529
Fix google_project
default network deletion by correcting URL
#2529
Conversation
google_project
default network deletion by correcting URL
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesWARNING: The following files changed in commit b11b640 may need corresponding changes in third_party/validator:
No diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
b11b640
to
a0a5b83
Compare
…RL (GoogleCloudPlatform#2529)" This reverts commit 2385346.
We started getting error since yesterday in our terraform module to create project. We delete default n/w in our terraform module. @rileykarson - We suspect this could be some recent change implemented. Our error message is google_project.project: Error deleting default network in project sbx-5064-test-project-07f972cf: Error waiting for Deleting Network: The network resource 'projects/sbx-zzzzz/global/networks/default' is already being used by 'projects/sbx-zzzzz/global/firewalls/default-allow-icmp' |
Yes- that's the error this fixes. See the linked issue at hashicorp/terraform-provider-google#4746. |
Fixes hashicorp/terraform-provider-google#4746
Fixing the tests I broke last week and noticed this one was a real failure. Enforcer conditioned me too well to ignore errors when firewalls were attached to networks 🤦♀
Release Note Template for Downstream PRs (will be copied)