Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nil reference to ShieldedNodes #2555

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Fix nil reference to ShieldedNodes #2555

merged 1 commit into from
Oct 30, 2019

Conversation

chrissng
Copy link
Contributor

@chrissng chrissng commented Oct 29, 2019

This PR fixes golang segmentation violation when referencing a nil ShieldedNodes object. Please see this issue for more info: hashicorp/terraform-provider-google#4756

Release Note Template for Downstream PRs (will be copied)

Fix nil reference to ShieldedNodes.

@chrissng chrissng changed the title Fix nil reference to Shielded Nodes Fix nil reference to ShieldedNodes Oct 29, 2019
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

@SirGitsalot, please review this PR or find an appropriate assignee.

Copy link
Contributor

@pdecat pdecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 20bb70b.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1314

@modular-magician modular-magician merged commit b12f9a0 into GoogleCloudPlatform:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants