Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for disallowing biquery-json service #2627

Merged
merged 3 commits into from
Nov 11, 2019
Merged

Add docs for disallowing biquery-json service #2627

merged 3 commits into from
Nov 11, 2019

Conversation

rileykarson
Copy link
Member

Docs for #2626

Release Note Template for Downstream PRs (will be copied)

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, a905599.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1347
depends: hashicorp/terraform-provider-google#4845

nat-henderson
nat-henderson reviewed Nov 11, 2019
View reviewed changes
third_party/terraform/website/docs/guides/version_3_upgrade.html.markdown Outdated

`bigquery-json.googleapis.com` is being renamed to `bigquery.googleapis.com` in
the upstream API. As a result, `bigquery-json.googleapis.com` has been
disallowed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add "Please use bigquery.googleapis.com - the provider will automatically convert between them as the upstream API migration continues."

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 60272f9.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

rileykarson and others added 3 commits November 11, 2019 19:21
@rileykarson @modular-magician
Add docs for disallowing biquery-json service
642f4ae
@rileykarson @modular-magician
Amend text based on review
94c30aa
@modular-magician
Update tracked submodules -> HEAD on Mon Nov 11 19:21:45 UTC 2019
c5ea781 
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 1857ae4 into GoogleCloudPlatform:master Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nat-henderson nat-henderson nat-henderson approved these changes

Assignees
No one assigned
Labels
automerged cla: yes downstream-generated terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rileykarson @modular-magician @nat-henderson @googlebot