Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CloudTasksQueue resource #2662

Merged
merged 2 commits into from
Nov 18, 2019
Merged

Add CloudTasksQueue resource #2662

merged 2 commits into from
Nov 18, 2019

Conversation

tysen
Copy link

@tysen tysen commented Nov 12, 2019 •
edited
Loading

Release Note Template for Downstream PRs (will be copied)

google_cloud_tasks_queue

@tysen tysen requested a review from slevenick November 12, 2019 22:11
@tysen tysen mentioned this pull request Nov 12, 2019
Closed
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 96f9af3.

Pull request statuses

No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1369
depends: GoogleCloudPlatform/terraform-google-conversion#260
depends: hashicorp/terraform-provider-google#4880
depends: ansible-collections/google.cloud#57

@tysen tysen requested a review from slevenick November 13, 2019 00:45
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 56fe3fd.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

slevenick
slevenick reviewed Nov 13, 2019
View reviewed changes
Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the preferred changelog note is: just google_compute_new_resource with the new-resource tag.

And can you enable the API in the CI project(s) and run the automated tests?

products/cloudtasks/terraform.yaml Show resolved Hide resolved
third_party/terraform/tests/resource_cloud_tasks_queue_test.go.erb Outdated Show resolved Hide resolved
third_party/terraform/tests/resource_cloud_tasks_queue_test.go.erb Outdated Show resolved Hide resolved
@tysen
Copy link
Author

tysen commented Nov 13, 2019

Updated the changelog entry and enabled the API in the one CI project I'm aware of.

@tysen tysen requested a review from slevenick November 13, 2019 01:10
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, daad11c.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@tysen tysen mentioned this pull request Nov 13, 2019
Closed
Ty Larrabee and others added 2 commits November 18, 2019 23:02
@modular-magician
Add CloudTasksQueue resource
6120936
@modular-magician
Update tracked submodules -> HEAD on Mon Nov 18 23:02:33 UTC 2019
417ba4e 
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 5183cf5 into GoogleCloudPlatform:master Nov 18, 2019
@modular-magician modular-magician mentioned this pull request Nov 27, 2019
Merged
@slevenick slevenick mentioned this pull request Dec 2, 2019
Closed
@modular-magician modular-magician mentioned this pull request Dec 3, 2019
Merged
@callppatel
Copy link
Contributor

When this resource will be available for google provider?

This was referenced Dec 6, 2019
Merged
Merged
@jmdobry
Copy link
Member

jmdobry commented Dec 10, 2019

Is there an automatic release where support Cloud Task Queues will become available?

@tysen
Copy link
Author

tysen commented Dec 10, 2019

It's in 3.1.0

@jmdobry
Copy link
Member

jmdobry commented Dec 11, 2019

Will it be back-ported to 2.x?

@tysen
Copy link
Author

tysen commented Dec 11, 2019

It won't be backported - we don't have the bandwidth to maintain two separate release chains.

@modular-magician modular-magician mentioned this pull request Dec 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slevenick slevenick slevenick approved these changes

Assignees
No one assigned
Labels
ansible automerged cla: yes downstream-generated terraform-google-conversion terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tysen @modular-magician @callppatel @jmdobry @slevenick @googlebot