Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require 'trigger_template' since it conflicts with 'github' in beta. #2717

Merged
merged 3 commits into from
Nov 19, 2019

Conversation

nat-henderson
Copy link
Contributor

@nat-henderson nat-henderson commented Nov 19, 2019

Fixes hashicorp/terraform-provider-google#4928.

Release Note Template for Downstream PRs (will be copied)

`cloudbuild`: Fixed incorrect dependency between `trigger_template` and `github` in `google_cloud_build_trigger`.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, b938bbb.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1410
depends: hashicorp/terraform-provider-google#4946
depends: ansible-collections/google.cloud#91

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also get a docs update mentioning that exactly one of the two must be specified?

@danawillow
Copy link
Contributor

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 9511344.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_cloudbuild_trigger requires trigger_template even for github triggers
4 participants