Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc and example for google_organization_iam_audit_config. #2788

Merged
merged 4 commits into from
Dec 6, 2019

Conversation

xingao267
Copy link
Member

Release Note Template for Downstream PRs (will be copied)

`organization`: Added documentation and example for `google_organization_iam_audit_config`

@xingao267
Copy link
Member Author

@slevenick PTAL, and let me know if any other files need to be modified or added.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 11f0000.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1474
depends: hashicorp/terraform-provider-google#5089

@slevenick
Copy link
Contributor

Thanks for adding this!

You will also need an entry in the website file that links to this doc. See

<li<%%= sidebar_current("docs-google-project-iam-x") %>>

for a similar block. It should be added near the existing google_organization_iam resources

@xingao267
Copy link
Member Author

Thanks for adding this!

You will also need an entry in the website file that links to this doc. See

<li<%%= sidebar_current("docs-google-project-iam-x") %>>

for a similar block. It should be added near the existing google_organization_iam resources

Done

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, fa5c089.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 1ddcb2b.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I'll get this merged

@modular-magician modular-magician merged commit 2a66927 into GoogleCloudPlatform:master Dec 6, 2019
@xingao267 xingao267 deleted the doc branch December 9, 2019 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants