Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add path_rules to UrlMap #2798

Merged
merged 3 commits into from
Dec 9, 2019
Merged

Add path_rules to UrlMap #2798

merged 3 commits into from
Dec 9, 2019

Conversation

tysen
Copy link

@tysen tysen commented Dec 6, 2019

Release Note Template for Downstream PRs (will be copied)

`google_compute_url_map now supports path_rules`

@tysen tysen requested a review from rileykarson December 6, 2019 21:27
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, f9951c9.

Pull request statuses

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1483
depends: GoogleCloudPlatform/terraform-google-conversion#281
depends: hashicorp/terraform-provider-google#5106
depends: ansible-collections/google.cloud#103
depends: modular-magician/inspec-gcp#265

rileykarson
rileykarson approved these changes Dec 9, 2019
View reviewed changes
products/compute/api.yaml Show resolved Hide resolved
Ty Larrabee and others added 3 commits December 9, 2019 19:59
@modular-magician
Add path_rules to UrlMap
51b28c7
@modular-magician
Make weight required
3eadb82
@modular-magician
Update tracked submodules -> HEAD on Mon Dec 9 19:59:25 UTC 2019
a8c5980 
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 48a5da1.

Pull request statuses

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1487
depends: GoogleCloudPlatform/terraform-google-conversion#282
depends: hashicorp/terraform-provider-google#5118
depends: ansible-collections/google.cloud#106
depends: modular-magician/inspec-gcp#268

@modular-magician modular-magician merged commit aea8804 into GoogleCloudPlatform:master Dec 9, 2019
@tysen tysen mentioned this pull request Dec 9, 2019
Merged
This was referenced Dec 10, 2019
Merged
Merged
This was referenced Jan 29, 2020
Closed
Closed
Closed
Closed
Closed
This was referenced Feb 12, 2020
Closed
Closed
Closed
@modular-magician modular-magician mentioned this pull request Mar 4, 2020
Closed
This was referenced Mar 18, 2020
Closed
Closed
This was referenced Mar 18, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileykarson rileykarson rileykarson approved these changes

Assignees
No one assigned
Labels
ansible automerged cla: yes downstream-generated inspec terraform-google-conversion terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tysen @modular-magician @rileykarson @googlebot