Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow compute_route priority to send empty values #2810

Merged

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Dec 10, 2019

Fixes hashicorp/terraform-provider-google#5131

Release Note Template for Downstream PRs (will be copied)

compute: fixed `google_compute_route.priority` to allow 0

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 410347e.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1495
depends: GoogleCloudPlatform/terraform-google-conversion#285
depends: hashicorp/terraform-provider-google#5135

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though in case you happen to be working late tonight hold off on merging this until the morning given the magician upgrades.

megan07 and others added 2 commits December 11, 2019 15:18
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 9aa86ab into GoogleCloudPlatform:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_compute_route ignores "priority = 0"
4 participants