update node pool workload metada config attribute

[thiagocaiubi]

Hello.

First, thank you for magic-modules.

I'm trying to fix hashicorp/terraform-provider-google#4041 but I'm struggling where I should make the change and how can I test the effects.

I can see the tests for workload_metadata_config were stripped out when the field moved from google to google-beta (#1008). The beta provider doesn't has any tests?

Where can I find an example to help me with the issue?

I'd appreciate you share your comments on this. Thank you!

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

@danawillow, please review this PR or find an appropriate assignee.

[danawillow]

Hi @thiagocaiubi, thanks for deciding to contribute! The tests that you pointed out actually do the reverse of what you were saying:

magic-modules/third_party/terraform/tests/resource_container_node_pool_test.go.erb

Lines 168 to 199 in f3b37e5

	<% unless version.nil? || version == 'ga' -%>
	func TestAccContainerNodePool_withWorkloadMetadataConfig(t *testing.T) {
	t.Parallel()
	cluster := fmt.Sprintf("tf-test-cluster-%s", acctest.RandString(10))
	np := fmt.Sprintf("tf-test-np-%s", acctest.RandString(10))
	resource.Test(t, resource.TestCase{
	PreCheck: func() { testAccPreCheck(t) },
	Providers: testAccProviders,
	CheckDestroy: testAccCheckContainerClusterDestroy,
	Steps: []resource.TestStep{
	{
	Config: testAccContainerNodePool_withWorkloadMetadataConfig(cluster, np),
	Check: resource.ComposeTestCheckFunc(
	resource.TestCheckResourceAttr("google_container_node_pool.with_workload_metadata_config",
	"node_config.0.workload_metadata_config.0.node_metadata", "SECURE"),
	),
	},
	{
	ResourceName: "google_container_node_pool.with_workload_metadata_config",
	ImportState: true,
	ImportStateVerify: true,
	// Import always uses the v1 API, so beta features don't get imported.
	ImportStateVerifyIgnore: []string{
	"node_config.0.workload_metadata_config.#",
	"node_config.0.workload_metadata_config.0.node_metadata",
	},
	},
	},
	})
	}

That unless statement is equivalent to "if not", so what it ends up meaning is "include the following section in the beta provider only". This is what we want, since WorkloadMetadataConfig isn't available yet in the v1 GKE API (https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1/NodeConfig). So I'd suggest having any changes you make be similarly guarded so that they only generate into the beta provider and not the GA one.

My guess from a first glance is that this change will be very similar to #2105, just in the node pool resource instead of the cluster one. Give it a try from here, and let me know if you have further questions!

[thiagocaiubi]

Hi @danawillow thanks for clarifying.

I was looking for the tests at google instead of google-beta. Sorry, my bad.

I will take a look and give it try.

Thank you! 👍

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[thiagocaiubi]

Hello @danawillow.

I have followed the steps in the PR you have mentioned but I'm still struggling with tests. Could you please take a look?

[danawillow]

Can you be more specific as to what you're having trouble with?