Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ExactlyOneOf restriction for auto_provisioning_defaults #3106

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Remove ExactlyOneOf restriction for auto_provisioning_defaults #3106

merged 1 commit into from
Feb 11, 2020

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Feb 10, 2020

Fixes hashicorp/terraform-provider-google#5545

Release Note Template for Downstream PRs (will be copied)

container: Removed restriction on `auto_provisioning_defaults` to allow both `oauth_scopes` and `service_account` to be set

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 10 deletions(-))
Terraform Beta: Diff ( 2 files changed, 10 deletions(-))

@c2thorn c2thorn merged commit 9ab0886 into GoogleCloudPlatform:master Feb 11, 2020
@c2thorn c2thorn deleted the autoprovisioning-scopes branch February 11, 2020 00:29
This was referenced Feb 11, 2020
Merged
Merged
@c2thorn c2thorn restored the autoprovisioning-scopes branch February 13, 2020 23:23
@c2thorn c2thorn deleted the autoprovisioning-scopes branch February 13, 2020 23:44
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
@c2thorn
Remove ExactlyOneOf restriction for `auto_provisioning_defaul… (Goo…
e82da80 
…gleCloudPlatform#3106)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danawillow danawillow danawillow approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

autoprovisioning scopes are wrong with service account
4 participants
@c2thorn @modular-magician @danawillow @googlebot