Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make connection reset error pred more generic, debug logs #3143

Merged
merged 3 commits into from
Feb 18, 2020

Conversation

emilymye
Copy link
Contributor

Make check for retrying "connection reset by peer" errors more generic

Continues hashicorp/terraform-provider-google#3957

@@ -67,18 +67,24 @@ func isIoEOFError(err error) (bool, string) {
return false, ""
}

const connectionResetByPeerErr = "connection reset by peer"

const connectionResetByPeerErr = ": connection reset by peer"
Copy link
Contributor Author

@emilymye emilymye Feb 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The underlying network error is always specifically something like $opType $ip -> $ip: $optype: $error so I think it's ok to try using this error with the colon

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 16 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 1 file changed, 16 insertions(+), 10 deletions(-))
TF Conversion: Diff ( 1 file changed, 16 insertions(+), 10 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 16 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 1 file changed, 16 insertions(+), 9 deletions(-))
TF Conversion: Diff ( 1 file changed, 16 insertions(+), 9 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 17 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 1 file changed, 17 insertions(+), 9 deletions(-))
TF Conversion: Diff ( 1 file changed, 17 insertions(+), 9 deletions(-))

@emilymye emilymye merged commit 09378a2 into GoogleCloudPlatform:master Feb 18, 2020
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
…dPlatform#3143)

* make connection reset error pred more generic, debug logs

* fmt

* import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants