-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make connection reset error pred more generic, debug logs #3143
Conversation
@@ -67,18 +67,24 @@ func isIoEOFError(err error) (bool, string) { | |||
return false, "" | |||
} | |||
|
|||
const connectionResetByPeerErr = "connection reset by peer" | |||
|
|||
const connectionResetByPeerErr = ": connection reset by peer" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The underlying network error is always specifically something like $opType $ip -> $ip: $optype: $error
so I think it's ok to try using this error with the colon
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 1 file changed, 16 insertions(+), 10 deletions(-)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 1 file changed, 16 insertions(+), 9 deletions(-)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 1 file changed, 17 insertions(+), 9 deletions(-)) |
…dPlatform#3143) * make connection reset error pred more generic, debug logs * fmt * import
Continues hashicorp/terraform-provider-google#3957