Allow projects/ prefix for the project field in project IAM resources
#3147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch allows the user to specify the value of the project field for project IAM resources as `project-id` or `projects/project-id`. Note that the above was already true for google_project_iam_policy [1]. This patch ensures that the above is also true for other project IAM resources like google_project_iam_member and google_project_iam_binding. [1] See commit 2f2f19f
slevenick
approved these changes
Feb 19, 2020
nathkn
pushed a commit
to nathkn/magic-modules
that referenced
this pull request
May 18, 2020
…es (GoogleCloudPlatform#3147) * Make iam_project.go.erb just .go * Allow `projects/` prefix for the project field in project IAM resources This patch allows the user to specify the value of the project field for project IAM resources as `project-id` or `projects/project-id`. Note that the above was already true for google_project_iam_policy [1]. This patch ensures that the above is also true for other project IAM resources like google_project_iam_member and google_project_iam_binding. [1] See commit 2f2f19f Co-authored-by: Jazel Canseco <jazel.canseco@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstreams hashicorp/terraform-provider-google#5722
Release Note Template for Downstream PRs (will be copied)