Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packet mirroring to beta. #3157

Merged
merged 6 commits into from
Feb 25, 2020

Conversation

nat-henderson
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

`google_compute_packet_mirroring`

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+))
Terraform Beta: Diff ( 8 files changed, 1364 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 8 files changed, 1364 insertions(+), 2 deletions(-))
Inspec: Diff ( 4 files changed, 7 insertions(+))

Copy link
Contributor

@chrisst chrisst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only 1 minor thing

- !ruby/object:Api::Type::String
name: description
description: A human-readable description of the rule.
input: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is forceNew?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is! Descriptions go that way most of the time. It's nuts.

required: true
description: |
A means of specifying which resources to mirror.
at_least_one_of:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+))
Terraform Beta: Diff ( 8 files changed, 1364 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 8 files changed, 1364 insertions(+), 2 deletions(-))
Inspec: Diff ( 4 files changed, 7 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+))
Terraform Beta: Diff ( 8 files changed, 1380 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 8 files changed, 1380 insertions(+), 2 deletions(-))
Inspec: Diff ( 4 files changed, 7 insertions(+))

@nat-henderson
Copy link
Contributor Author

My unit test is running into quota issues, so I'm going to submit since running "terraform apply" with this test's config worked during development. If the test fails in the nightly I'll fix it from there.

@danawillow
Copy link
Contributor

TPG make website-test is failing due to broken link (probably needs to be beta-guarded), can you fix?

@nat-henderson
Copy link
Contributor Author

Ah, shoot, sure.

nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
@nat-henderson nat-henderson deleted the packet-mirror branch January 4, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants