-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add packet mirroring to beta. #3157
Add packet mirroring to beta. #3157
Conversation
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 1 file changed, 4 insertions(+)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only 1 minor thing
- !ruby/object:Api::Type::String | ||
name: description | ||
description: A human-readable description of the rule. | ||
input: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is forceNew?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is! Descriptions go that way most of the time. It's nuts.
products/compute/api.yaml
Outdated
required: true | ||
description: | | ||
A means of specifying which resources to mirror. | ||
at_least_one_of: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure the syntax is correct on this: https://github.com/modular-magician/terraform-provider-google-beta/compare/auto-pr-3157-old..auto-pr-3157#diff-3ab2ba91e18e29d378d69f103ff962d0R108
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 1 file changed, 4 insertions(+)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 1 file changed, 4 insertions(+)) |
My unit test is running into quota issues, so I'm going to submit since running "terraform apply" with this test's config worked during development. If the test fails in the nightly I'll fix it from there. |
TPG |
Ah, shoot, sure. |
Release Note Template for Downstream PRs (will be copied)